We are glad to accept your contributions. As we told, this baseline computing module is from you private/internal APM system, this will help skywalking to provide more features. Thanks.
Here is my guideline:
baseline-computing, and path is /apm-collector/apm-collector-baseline/collector-baseline-computing-define. You should define the baseline services, which represent as Java interfaces, like many rpc frameworks did. You should register them in module define through the return list of ComputingModule#services. @Override public Class[] services() {
return new Class[0];
}
provider for this module, that is why I set up a provider, named default, and path is /apm-collector/apm-collector-baseline/collector-baseline-computing-provider.#prepare, by using #registerServiceImplementation. The serviceType parameter should be the service, you defined in module, and the service parameter should be your implementation of the first parameter service.provider module.And there are some attentions:
check-sytle works, so make sure you imported the style file, and ci passed.java.header file, please make sure your IntelliJ preference setting is right. It should add the heads automatically.Looking forward your pull request.
If you need any help, you know how to find me.
Thanks.
Skywalking PMC team.
FYI @OpenSkywalking/pmc @OpenSkywalking/committer-team @OpenSkywalking/huawei-devcloud-contributor-team
I care about the data structure of the services.
@beforeeight
Can you share some experience about the baseline?
Most helpful comment
FYI @OpenSkywalking/pmc @OpenSkywalking/committer-team @OpenSkywalking/huawei-devcloud-contributor-team