Site-www: Bad URL in server homepage

Created on 13 Jun 2020 · 9Comments · Source: dart-lang/site-www

Page URL: https://dart.dev/server/
Page source: https://github.com/dart-lang/site-www/tree/master/src/server/index.md

Found a typo? You can fix it yourself by going to the page source and clicking the pencil icon. Or finish creating this issue.

Description of issue:

gRPC Quicstart HTML link is wrong. Must be

https://grpc.io/docs/languages/dart/quickstart/
not
https://grpc.io/docs/languages/dart.html/quickstart/

bad URL beginner e0-minutes help wanted p2-medium

Source

vgazioglu

👍1

Most helpful comment

I changed the link in my repo and made a PR #2489 :)

Lilymage on 19 Jun 2020

❤1 🎉1

All 9 comments

Thank you, @vgazioglu! This should be easy to fix by editing the page source in the GitHub UI. Any takers?

kwalrath on 15 Jun 2020

👍1

Hi, I tried my first PR on this!

Lilymage on 16 Jun 2020

🎉1

Hi, I tried my first PR on this!

Cool! Just to make sure you know, you can edit this file in the page source without even creating a local version of the site-www repo.

(Not that there's anything wrong with having the whole repo... but it isn't necessary for this typo fix.)

kwalrath on 17 Jun 2020

Hmm, I tried editing the page by clicking on the little pencil, but I got this note :
" You’re making changes in a project you don’t have write access to. Submitting a change will write it to a new branch in your fork Lilymage/site-www, so you can send a pull request. "
Is there something I am not doing right ?

Lilymage on 18 Jun 2020

Nope, you're doing it exactly right. Keep going!!

kwalrath on 18 Jun 2020

can I also help in this

Mihir-Bhasin on 19 Jun 2020

👍1

I changed the link in my repo and made a PR #2489 :)

Lilymage on 19 Jun 2020

❤1 🎉1

can I also help in this

@Lilymage already fixed this one, but you're welcome to make other doc fixes, @Mihir-Bhasin!

kwalrath on 19 Jun 2020

Ok my pleasure thank you

On Fri, Jun 19, 2020, 8:18 PM Kathy Walrath notifications@github.com
wrote:

can I also help in this

@Lilymage https://github.com/Lilymage already fixed this one, but
you're welcome to make other doc fixes, @Mihir-Bhasin
https://github.com/Mihir-Bhasin!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/site-www/issues/2484#issuecomment-646678253,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANTZ5U2NLPC4DLCQDXDCN23RXN3CFANCNFSM4N5BWWMQ
.