Site-www: futures codelab needs tests for examples

Created on 3 Aug 2019  路  9Comments  路  Source: dart-lang/site-www

(1) We should write tests for the test code that runs in DartPad exercises
(2) We should extract / test the code in example snippets.

Ed 10/23: We should update the codelab's test code to use Andrew's test package. (The test code was written before the package was finished.)

DartPad bug codelabs e2-days study p2-medium

All 9 comments

Details from previous offline discussion

We need tests for test code: 1. ensure solution code works 2. feed failing code and check out test result and custom error messages

cc: @RedBrogdon I'm not sure which repo should we use to track this.

@galeyang Sorry, I should have clarified in the initial description:

(1) should probably be tracked in dart-lang/dart-pad @RedBrogdon please correct if I'm mistaken about this
(2) can be tracked in dart-lang/site-www (this issue) since we currently have a mechanism for doing this repo

If we could get the DartPads' code from arbitrary repo files, not just gists, then (2) could possibly take care of (1) for this site.

@legalcodes could you update the status of this?

AFAIK we can't move forward on this before https://github.com/flutter/website/issues/3262 is resolved, though to be 100% certain we'd need to verify that the issue exists for dart-lang/site-www.

Looks like flutter/website#3262 has been resolved.

This codelab uses gists, so IIRC in order to add testing we're also waiting for an update on https://github.com/dart-lang/dart-pad/issues/1120.

@RedBrogdon can you please advise?

2454 changed the codelab to use embedded code, rather than gists. So now the code is analyzed, but the tests still aren't being automatically run.

Was this page helpful?
0 / 5 - 0 ratings