Site-www: Simplify the docs around what to ignore

Created on 11 Mar 2017  路  16Comments  路  Source: dart-lang/site-www

Page: https://www.dartlang.org/guides/libraries/private-files

See the rational here: https://github.com/dart-lang/stagehand/commit/1f801774609cdc3013ba9f6ae8b43fab555c95f2

I'd also argue for removing the dartdoc item. Most folks don't generate docs locally 鈥撀爐hey rely on dartdot.org

We should optimize for the 95% case to keep this simple.

beginner e0-minutes help wanted p2-medium

Most helpful comment

I think it's fine to leave the dartdoc bit 鈥撀燼lthough I think it's pretty rare for folks to generate docs directly in their package -聽not sure.

I think we can remove Avoid committing generated JavaScript files: 鈥撀燼ll of our recommended flows have folks using our build system 鈥撀爓hich puts everything in the build directory. And that's already handled.

All 16 comments

I see that Kevmoo fixed this. Closing.

Nope. I fixed stagehand and GitHub's defaults.

We still need to update https://www.dartlang.org/guides/libraries/private-files

@kevmoo Do we really need to simplify private-files? I'd rather have it be complete than remove something and have someone not be able to find info they need. I think of it as a reference doc, more than a how-to doc, since stagehand and other standard files take care of the 95% case.

I think it's fine to leave the dartdoc bit 鈥撀燼lthough I think it's pretty rare for folks to generate docs directly in their package -聽not sure.

I think we can remove Avoid committing generated JavaScript files: 鈥撀燼ll of our recommended flows have folks using our build system 鈥撀爓hich puts everything in the build directory. And that's already handled.

So it looks like all we need to do is remove this:

image

Hey @kwalrath , I would like to contribute to this.
Can you give a brief rundown on what's been done and what stills needs to be fixed?

Thanks for offering to help!

I think all we need to do is what's in my preceding comment (i.e., remove the paragraph and example about generated js files).

@kwalrath I removed the Avoid committing generated JavaScript files: section in the above referenced PR.

Also are the sections in the below sections still relevant after dart-lang/stagehand#549 and #1850 ??
Screenshot_12

Also are the sections in the below sections still relevant after dart-lang/stagehand#549 and #1850 ??

@kwalrath can you confirm this ? Otherwise I think it's safe to assume that this issue can be closed

Good catches! You're right that the "*.js" section can be deleted.

We should use a different example for the .gitignore paragraph. It probably shouldn't be IDE files, since those would be covered by the global gitignore.

Can you think of a good example of a project-specific file to be ignored?

@kwalrath

Good catches! You're right that the "*.js" section can be deleted.

Will do just that

We should use a different example for the .gitignore paragraph. It probably shouldn't be IDE files, since those would be covered by the global gitignore.

Can you think of a good example of a project-specific file to be ignored?

Some possible files can be something keys.txt or other library/dependency files that you might want the end user to download (node modules etc)

keys.txt makes sense to me.

keys.txt makes sense to me.

Alright then I'll remove the .js section and restructure the .gitignore paragraph

@kwalrath Should be fine to close this issue?-

Thanks, @Purukitto!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

miquelbeltran picture miquelbeltran  路  5Comments

sarahec picture sarahec  路  3Comments

kwalrath picture kwalrath  路  5Comments

feinstein picture feinstein  路  4Comments

jonasfj picture jonasfj  路  3Comments