Site-kit-wp: Core Site Kit Functionality | Client ID/Secret entry

Created on 15 Jul 2019  路  6Comments  路  Source: google/site-kit-wp

Set up testing for Core Site Kit Functionality, Client ID/Secret entry. Note this was perviously set up with WP Assure here: https://gitlab.10up.com/google/google-site-kit-tests/merge_requests/1


_Do not alter or remove anything below. The following sections will be managed by moderators only._

Acceptance criteria

  • N/A

Implementation Brief

  • N/A

Changelog entry

  • N/A
P2

Most helpful comment

@circlecube Please make sure to assign the issue as applicable next time: Either just unassign yourself if you completed the first iteration, or unassign yourself and assign back the original reviewer if you worked on it as part of a request for changes. :)

Just assigned this back to @swissspidy accordingly.

All 6 comments

I worked on this today and have made good progress. Should be able to clean it up and submit for review tomorrow.

Tests in place for:

  • disabled button on load
  • disabled button on invalid data
  • enabled button on valid data
  • pressing button with valid data brings user to step 2

@circlecube - I believe @swissspidy left some comments on the CR for you to address. Moving this back to Development for that work. Once you're finished, just move this back to Code Review for a second pass. Thanks!

Thank you @lilybonney, issues are addressed and back to code review with @swissspidy now.

@circlecube Please make sure to assign the issue as applicable next time: Either just unassign yourself if you completed the first iteration, or unassign yourself and assign back the original reviewer if you worked on it as part of a request for changes. :)

Just assigned this back to @swissspidy accordingly.

Review done, now awaiting QA.

HEADLESS=false npm run test:e2e -- tests/e2e/specs/auth-client-configuration.test.js

Test Suites: 1 passed, 1 total
Tests: 3 passed, 3 total

QA looks good

Was this page helpful?
0 / 5 - 0 ratings