Site-kit-wp: Publish the plugin in packagist

[ekandreas]

Is your feature request related to a problem? Please describe.
Please publish the plugin in packagist so that it is reachable with a standard composer based WordPress installation.

Describe the solution you'd like
Packagist publication

Describe alternatives you've considered
Manual git config

Additional context

---

_Do not alter or remove anything below. The following sections will be managed by moderators only._

Changelog entry

Acceptance criteria

[swissspidy]

Just submitting the package is probably not enough, as it would need a dist version with built JS but without the bundled Composer packages.

[felixarntz]

Thanks for the issue!

We will explore that as an option. Once the stable release of the plugin is there, it will be available via wpackagist.org. For now, you can install it via Composer by providing something like this in your composer.json:

  "repositories": [
    {
      "type": "package",
      "package": {
        "name": "google/google-site-kit",
        "version": "1.0.0-beta.1",
        "type": "wordpress-plugin",
        "dist": {
          "type": "zip",
          "url": "https://sitekit.withgoogle.com/service/download/google-site-kit.zip",
          "reference": "1.0.0-beta.1"
        }
      }
    }
  ]

[ekandreas]

It’s not a release without a dist, no.
And adding a repo endpoint to every package feels just so wrong when we all have packagist as default.

[archon810]

+1 for this, I was just about to submit it myself https://packagist.org/packages/submit?query=google%2Fsite-kit-wp and then found this ticket.

Why not just submit it there now, before it's fully released to stable, so that we can start using it without adding the github repo to our composer?

[swissspidy]

@archon810 As mentioned earlier in this thread, we cannot "just submit it there now", because the package would lack all the necessary built JavaScript and CSS assets.

Plus, the plugin would need to be tweaked to not include its own autoloader at all times:

https://github.com/google/site-kit-wp/blob/13ca8a74557e1c6a1da178762eaeaab04ea46447/includes/loader.php#L17-L18

That's because with a Composer setup there is no vendor folder within the plugin's folder itself.

Essentially, it would mean that we basically have to maintain two versions of the plugin:

• One suitable for distribution via Packagist
• One fully packaged for release on WordPress.org

[ekandreas]

That is just not true.

[swissspidy]

@ekandreas Happy to be convinced otherwise :-) Can you perhaps elaborate on why that wouldn't be true? How do you intend to use this plugin using Composer?

To give some more context, we are currently in the same situation with the AMP plugin (https://github.com/ampproject/amp-wp/issues/2649) and, according to a recent blog post, Yoast as well (https://developer.yoast.com/safely-using-php-dependencies-in-the-wordpress-ecosystem/)

[ekandreas]

Compile and check in the assets in the dist folder. Composer is taking care och the autoloading.
Take a look at Roots Bedrock, WordPlate or any other standard Composer based WP solutions.

[ekandreas]

Or just write that the assets needs to be compiled. It’s not a big thing to add it in the ci/cd-process.