Simple_form: Rails 5 support

[rafaelfranca]

This is an issue to track the other issues that are required to be have support to Rails 5.

[terry90]

undefined method `number?' for #<ActiveRecord::ConnectionAdapters::PostgreSQLColumn:0x007fd63ddc2ad8>

On a f.input :field

[fanta]

@terry90 glad I'm not the only one

ActionView::Template::Error (undefined method `number?' for #<ActiveRecord::ConnectionAdapters::MySQL::Column:0x007fd8bb68e110>

[fanta]

In the mean time, we can add maxlength: 100 or whatever number to our inputs. What I found is that active_record/connection_adapters/column.rb does not have a number? method which is being used in simple_form-3.2.1(or your version)/lib/simple_form/inputs/base.rb in the decimal_or_float? method like this: column.number? && column.type != :integer, if you change that line perhaps to column.scale && column.type != :integer it works, but I'm not sure if using column.scale is the best way to know if it has a decimal point or not.

[rafaelfranca]

I should make clear that I'm not going to focus on fixing those issues for a while so if people want to investigate and open pull requests please go ahead.

[fuzzygroup]

should make clear that I'm not going to focus on fixing those issues for a while so if people want to investigate and open pull requests please go ahead.

Can you define "a while"? I don't know if you mean days, weeks or Performatec just isn't interested. Thanks!

[rafaelfranca]

I can't speak for Plataformatec but I'm not using simple form for more than
3 years now and it is not my top priority. I reserved a night per week to
work on simple form but I may take weeks to actually do any work on the
rails 5 compatibility issue.
On dom, 3 de jul de 2016 at 09:51 J. Scott Johnson [email protected]
wrote:

should make clear that I'm not going to focus on fixing those issues for a
while so if people want to investigate and open pull requests please go
ahead.

Can you define "a while"? I don't know if you mean days, weeks or
Performatec just isn't interested. Thanks!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/plataformatec/simple_form/issues/1395#issuecomment-230151972,
or mute the thread
https://github.com/notifications/unsubscribe/AAC66PamK13VFsDdwh6cuhCU26P4bW_iks5qR7BEgaJpZM4I7Thm
.

[fuzzygroup]

Ah. Now worries then. Thank you for the quick reply.

[afroniquely]

Anyone has other fixes on this issue? I got the same warning as above

[lucasmazza]

Hey everyone, please see https://github.com/plataformatec/simple_form/pull/1342#issuecomment-242468917 and try out Simple Form 3.3.0. If we don't got any new issues regarding Rails 5 we can close this one in a couple of days.

[rafaelfranca]

:+1:

[thomasfedb]

Has this issue been resolved? If simple_form works with Rails 5 would be great to mention that here and close this issue.

[murb]

5.1 issues have already been solved, so I guess 5.0 support is hardly an issue at this moment.

[lucasmazza]

@thomasfedb @murb yes - latest release is both 5.0 and 5.1 compatible.