Signal-desktop: Missing reactions

[rainerzufall]

• [x] I have searched open and closed issues for duplicates

---

Bug Description

• I used the new "any emoji reactions" in a group over the weekend. My Signal desktop apps were offline for little over 2 days. The reactions are displayed on my phone, but are missing on all of my 3 desktop apps, upon starting them up.
• It does not seem that there are any messages missing. At first glance the message queue was not reached and therefore it seems not plausible that the missing message reactions were omitted this way.
• I have verified that those reactions have been received by at least one of the other group members.
• Interestingly not all reactions sent during the weekend are missing from this group (but all of my reactions): Notably one of the old/regular reactions made by an other group member has been received by my phone as well as all three desktop apps.
• That the one old reaction is visible and my new "any emoji" reactions not could be purely coincidental

Screenshots

one of the missing reactions (there are four more reactions missing in total; I can provide their IDs if helpful)

• Android:
  

Android message ID: 1591531679868 (message was not sent by me; unfortunately can't find it in the Android log, hopefully the report is still helpful )

• Desktop 1:
  

Gesendet | Sonntag, 7. Juni 2020 14:07 (1591531679868)
-- | --
Empfangen | Sonntag, 7. Juni 2020 23:22 (1591564976966)

• Desktop 2:

Gesendet | Sonntag, 7. Juni 2020 14:07 (1591531679868)
-- | --
Empfangen | Montag, 8. Juni 2020 10:50 (1591606248560)

---

received reaction

Android message ID: 1591543638639 (same as above applies to this ID)

• Desktop 1:

Gesendet | Sonntag, 7. Juni 2020 17:27 (1591543638639)
-- | --
Empfangen | Sonntag, 7. Juni 2020 23:22 (1591564978932)

• Desktop 2:

Gesendet | Sonntag, 7. Juni 2020 17:27 (1591543638639)
-- | --
Empfangen | Montag, 8. Juni 2020 10:50 (1591606248714)

---

Platform Info

Signal Version:

• Desktop 1:
  SignalBeta/1.34.0-beta.3

• Desktop 2:
  Signal/1.34.1

Operating System:

• Desktop 1:
  Windows 10* 64-bit

• Desktop 2:
  Windows 7* 64-bit

Linked Device Version:

• Android: Signal 4.62.2 (6502); Android 9

Link to Debug Log

Desktop 1:
https://debuglogs.org/d477bca8ab8a57ff236e7c0617a58075fa2b5a666d12787f162cafef2ff99cf7

Desktop 2:
https://debuglogs.org/8a7f90f4bd7f4f04ed3265509605b60270f46269412065d9b3f441fd7a90cca4

Android:
https://debuglogs.org/114a8e8f17e13fa1c99e631b60e72945413e19b92f00889214f20bb2a635faf4

[rainerzufall]

Do more debug logs (and message IDs) help to track this down or did you already understand why this is happening?
There is definitely some bug here. I just started up Signal Desktop and in one group only 2 out of 23 emoji reactions have "survived" on Signal Desktop (all these reactions were sent during the last hour where Signal Desktop was offline).
On my second Signal Desktop instance 3 out of the 23 reactions made it through... (In some kind of extreme coincidence all 5 of them are "😂" emojis... I know that can't be connected to the bug, but mentioning it, since it is a strange coincidence)
Again no queue overflow is realistic, since I start my Desktop apps on a daily basis. Since Signal Desktop is back online all reactions are displayed correctly.

[rainerzufall]

Looks like https://github.com/signalapp/Signal-Desktop/commit/4289c28a38b5908684590482ff1c5eed523bec31 improved the behaviour a lot!!! In my testing and trying to break things ;) around 7 emoji reactions did not make it through, but the rest now made it through :) Not sure how many reactions I sent, probably 60 - 100 all in all.

3 of the not received ones:

1.

• Android message ID:
  1594719143567

• Desktop ID

Gesendet | Dienstag, 14. Juli 2020 11:32 (1594719143567)
-- | --
Empfangen | Donnerstag, 16. Juli 2020 16:47 (1594910842892)

2.

• Android message ID:
  1594719144461

• Desktop ID

Gesendet | Dienstag, 14. Juli 2020 11:32 (1594719144461)
-- | --
Empfangen | Donnerstag, 16. Juli 2020 16:47 (1594910842892)

3.

• Android message ID:
  1594719145285

• Desktop ID

Gesendet | Dienstag, 14. Juli 2020 11:32 (1594719145285)
-- | --
Empfangen | Donnerstag, 16. Juli 2020 16:47 (1594910842893)

Desktop log (like Desktop 1 above; now on _SignalBeta/1.34.4-beta.1_):
https://debuglogs.org/7add16e9539e01fa610958f9d43267fa8b4eb8c62a091b530cfbe85999dac00a

Android log:
https://debuglogs.org/4463ff93cb27aa1d815f02349e9a86b8bb6db0dd9535394eb8fab61d122af294

---

EDIT: I did go through my groups, where reactions were also sent after I upgraded to the newest desktop beta - and there I can find also a few reactions missing on desktop. Mainly from other people. They are received on my phone, but did not survive to the desktop app. Do more examples with message IDs help? I could try to get some more logs... Just tell me.

[shortenjukebox]

It seems I’m having this issue as well, but my Signal Desktop device was not offline for more than a day.

https://debuglogs.org/e2fafaf0c05ce05a41e4df2f8cd4c90831d88827860c978db786a30b0dd092f0

If you don’t mind a suggestion @ainerzufall, I would retitle the issue to Sent reactions missing from group conversations. I was writing what would have been a duplicate issue before I realized what “any emoji reactions” meant.

Huge thanks in advance to the devs, when y’all can get to this.

[rainerzufall]

@shortenjukebox I can definitely remove the "any emoji" part. Other than that I also experienced it in 1on1 conversations as well as on received emoji reactions, so your suggested title would narrow it down too much.

[shortenjukebox]

Ah strange, the issue doesn’t occur in my single-recipient conversations (as far as I can tell)

From: rainerzufall [e-mail]
To: signalapp/Signal-Desktop [e-mail]
CC: shortenjukebox , Mention [e-mail]
Received: Sep 27, 2020 04:03:31
Subject: Re: [signalapp/Signal-Desktop] Missing reactions (possibly related to the new "any emoji reactions") (#4336)

@shortenjukebox[https://github.com/shortenjukebox] I can definitely remove the "any emoji" part. Other than that I also experienced it in 1on1 conversations as well as on received emoji reactions, so your suggested title would narrow it down too much.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub[https://github.com/signalapp/Signal-Desktop/issues/4336#issuecomment-699601251], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABB4LRRF45EIGXJ6OBLG3NLSH3WVFANCNFSM4NYRPYTA]. [https://github.com/notifications/beacon/ABB4LRW7R33COPO4DUHSPH3SH3WVFA5CNFSM4NYRPYTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFGZRCYY.gif]

[dinosmm]

For the past two weeks I’ve noticed that some reactions and some messages don’t sync between phone and desktop, which sounds like the same issue. In my case though, both phone and desktop are connected all the time. The desktop may have periods of being switched off, but these are few and far between.
I may send a message from the desktop that doesn’t appear on the phone, or react to a message on desktop and the reaction does not appear on the phone.
I haven’t kept count but I think it is happening more from desktop to phone than the other way round.
Connectivity in all cases has been very good on both devices.

The logs below concern a reaction from desktop that did not sync to phone, this happened 35min before the logs were taken. Both devices had full connectivity at the time.

Debug log from phone:
https://debuglogs.org/20074c86643239d6307e305acd4849db5bd1fa0b192b7830e9e211c5f8a659d6

Debug log from desktop:
https://debuglogs.org/5a73a36352f3b977a5ab9209a972c5045c78f8c93a69c9e86e410acc302f272d

[DirkPitt1]

I didn't see any missing reactions but any picture sent without caption in GV2 group from Desktop app isn't visible on my phone. Pictures with captions are visible. This issue doesn't occur when I send from my phone or from desktop in legacy groups and 1:1 chats.

Edit: OK, I've just seen that some my reactions from Desktop are missing in Android.

Debug log from Desktop
https://debuglogs.org/14c715a0c511f6bf24358ce0a3585363d8ea3925419987450017b02c7838ee1c

Debug log from phone
https://debuglogs.org/2e865aaa29486119d99b3f01859c22c4f40a17b5504ec429d1148ab2d6b6bbae

[EvanHahn-Signal]

Thanks. No updates, but these debug logs are helpful.

[dinosmm]

More testing reveals that NO reactions done in a v2 group on my ipad sync to my phone.

Reactions done on the ipad in a v1 group always sync to my phone.

Ipad v3.18.0.5
Android v4.72.2

Debug log from ipad:
https://debuglogs.org/70b8479f1f58e26893493e9f4958f133e3500b61d499a4263d60d1b65fee6306.zip

Debug log from phone:
https://debuglogs.org/0917aa22543d0bf4edb31188e384f209c1a458f2a63c89b95d5a9aa34143233a

[severus-tux]

I have the same issue. My own reactions which I posted from my desktop client are not appearing on my android client

On Desktop:

Debug log - Signal Desktop v1.36.3-beta.2 on Ubuntu 20.04
https://debuglogs.org/0bc650797ea9f2e0ff3ac457e90019d5e1edb0eb1ba16b3acfa3cc686356ae62

On Android:

Debug log - Signal Android 4.72.2 on Lineage OS (Android 9)
https://debuglogs.org/12f23730723f08b7f0d300d75664bb64865ed106c35efbf43179388b15d7360c

[rainerzufall]

https://github.com/signalapp/Signal-Android/commit/caf8bb39d860675c301d20ba8188bfa04f7de592 fixed the issue with reactions not being sent from Desktop to my own devices! 🥳

But even after updating there are still occasions of missing reactions. Received on mobile, but not on Desktop, for example:

1. ANDROID
   (where one reaction of a person whose number ends with 623 is NOT missing):
   

• Message ID on Android:
  sent: 1601366464240
  received: 1601366464668

• debug Android:
  https://debuglogs.org/52a5cef8a6d668b2c217d380521dabe91f3c482c724fe475f4dc8da3ecb77ff2

---

1. DESKTOP
   (where one reaction of a person whose number ends with 623 is missing):
   

• Message ID Desktop :

Gesendet | Dienstag, 29. September 2020 10:01 (1601366464240)
-- | --
Empfangen | Dienstag, 29. September 2020 10:27 (1601368068888)

• Debug log Desktop:
  https://debuglogs.org/ae1115806bb59e362fe5ebf905d3acda5d7e4540fae340b12928629339b42827

[kaktusztea]

Hi,

I had this issue again with up-to-date stable versions.
I have one iPhone as main device and two linked desktops (Mac OSX, Win10).

• Signal iOS: 3.17.5.1
• Signal Desktops: 1.36.3

I sent the message from Desktop-1 to a group, it got 5 reactions.
The message appeared well on iPhone, all reactions were in place.

But I have a linked Desktop-2 (Win10) as well, what was offline for 2 days.
When I started Desktop-2, messages were synced, my very message was there well, but only 3 of 5 reactions appeared.

I don't think message limit (1000) was reached, there were no big traffic during this 2 days.
Time between message was sent and Desktop-2 was started: ~16 hours.

Message
Sent: 1601395100915
Sender: xxx759

Missing reaction's sender-1: xxx873 (Android)
Missing reaction's sender-2: xxx269 (Android)

Desktop-1 (message sender) log:
https://debuglogs.org/eb50c1cbf91a8ba79062b5d8c115c9871b8866931abef2ed882383f64711bd58

Desktop-2 log:
https://debuglogs.org/a9e1340d818b079758675330f9d30da0652d21a0870de51323084c29452ecf60

iPhone log:
https://debuglogs.org/a1280cab9f4c2d198782903ba34b759949b3ad37b239a58c9ca7f3b8ca217373.zip

[kaktusztea]

I still have regulary problems (only on desktop clients) with missing reaction emojis.

Last time I received 2 messages in a group (from the same person) and I put 1-1 reaction emojis on them - from my primary (mobile) device (iPhone). Later I opened my laptop, Signal Desktop synced all messages, but my reactions were not there.

Message-1: 1603705748377 (sent timestamp)

• sender phone number: xxx377
• it's a received message from a friend in a group
• it arrived and message order is also OK, BUT it has no reaction emoji on it - that I put on it

Message-2: 1603705776497 (sent timestamp)

• sender phone number: xxx377
• this message is received from the same friend in the same a group, right after the previous one
• same situation with the missing reaction emoji that I put on it
• extra info: this message contains a quote from one of my earlier message, but maybe it's not relevant

My primary device: iOS 14.1, Signal v3.21.0.10
https://debuglogs.org/c3d4d4c1eb70f1c2e0b7f3beefbccbcd1d67ba5ec26ca362bdd21de8bac69725.zip

My Desktop-1: Signal v1.37.2 (Mac OSX)
https://debuglogs.org/94aaf1ac4895c922f2e0dd907f1e43627ffeb34f675f723326d4558268e20cd9

My Desktop-2 (Win10) is offline for 5 days now.

Friend has an Android primary device and a Linux desktop client. He sent the 2 messages from his desktop clent. The messages arrived in order on all my devices - the problem is only with reaction emojis.

Friend linux desktop (v1.37.2) debug log:
https://debuglogs.org/23ff0dc4a5908cc08d1fe03b9c52f5bc9c26079408f8be6f0de9de8814c2e3c2

One additional detail that might doesn't matter: my friend replaced today his phone and reinstalled Signal on that (Android) - security number changed. But all his messages above came after this act.

The group is a v1 (legacy) type group.

[scottnonnenberg-signal]

We have a fix for missing reactions coming out in our next release - please try things out on our next build!

[kaktusztea]

Hi @scottnonnenberg-signal
It looks like 1.37.3 solved the issue 🙂

[scottnonnenberg-signal]

Glad to hear! I'll let @rainerzufall close this issue. :0)

[rainerzufall]

@scottnonnenberg-signal Thanks for the honors, I would be happy to and I hate to say this, but it looks like the issue is not solved yet. :(
We are doing extensive missing reactions testing in a group of more than 70 people...

• on Android: (9 reactions)
  

message ID: 1604597260402
log: https://debuglogs.org/11a654e97b4244db86491602876ecdc2fdb481dd9c37c8f11a124c7ca076f365

---

• on Desktop (only 4 reactions):
  

message ID:
Gesendet | Donnerstag, 5. November 2020 18:27 (1604597260402)
-- | --
Empfangen | Donnerstag, 5. November 2020 18:27 (1604597260402)

log: https://debuglogs.org/fd83a866c2b4342a635ff0813d59f56608a1ce29d6377794989b4ca19f746bd3

additional info:

• two group members with Signal Desktop on Linux, can see all nine reactions to this message.

I could give you more message IDs we can see several other messages with missing reactions. Please let me know what info would help you.

[rainerzufall]

made a comparison of all placed reactions so far:

[kaktusztea]

Could it be different if it's a GV1 or GV2 group..?
Most of my groups are still GV1 and they behave OK (not like before).