Signal-desktop: Clicking on quoted replies to attachments opens up the file saver dialog

[Xashyar]

• [x] I have searched open and closed issues for duplicates
  

---

Bug Description

Clicking on replies to attachments brings up the file chooser/saver dialogue.

Steps to Reproduce

1. reply to an attachment
2. click on the reply
3. see file saver pops up

Actual Result:
Unnecessary dialogue pops up.

Expected Result:
Unnecessary dialogue is avoided.

Platform Info

Signal Version: 1.30.0-beta.6

[scottnonnenberg-signal]

Where exactly are you clicking to make this happen? I'm not seeing it. Maybe a screenshot might be useful?

[scottnonnenberg-signal]

Hm. Again, not seeing it. I have the same setup, replying to a non-visual attachment with another non-visual attachment. When I click on the reply, the original message is highlighted.

[denver-s]

I can reproduce the bug!

1. Sent a random PDF (A) on my PC
2. Replied to it with another different PDF (B)
3. Clicking on the replied message A shows the download window for document B

This is probably because all the message B area is clickable for download (like when you click on the filename you get the "Save in..." window).

[scottnonnenberg-signal]

So, if I'm following: in that screenshot, you clicked on the dark blue reply part of the message, and instead of the original message right above it being highlighted, you got the 'Save As' dialog for the attachment in that second message. Is that correct?

[Xashyar]

you clicked on the dark blue reply part of the message, and instead of the original message right above it being highlighted, you got the 'Save As' dialog for the attachment in that second message. Is that correct?

Yes.

[scottnonnenberg-signal]

Thanks for your help on this - a fix will be released shortly!

[Xashyar]

Unable to reproduce as of https://github.com/signalapp/Signal-Desktop/commit/bfa76b05d29dbb97683ba87818cd9b3d2f6d9f61