Signal-desktop: This one photo message I sent from Signal-Android just refuses to get downloaded on Signal-Desktop

[Dyras]

• [x] I have searched open and closed issues for duplicates
  

---

Bug Description

I sent a picture of my Bowser plush from my Signal-Android to a friend. She can see the picture and I can see the picture on my phone. On the computer, the image is just spinning endlessly and has been doing so for half an hour now.

Steps to Reproduce

I dunno, sorry. I'm not using a VPN, so that's not the problem. My connection works fine, so that's not the problem. I'm uploading a file at 70 kb/s on my 10 megabit upload over Resilio Sync, so that's not the problem.

I tried restarting Signal-Desktop and it didn't help

Actual Result:
The picture isn't downloading, or maybe it's just not displaying. I took it with my Pixel XL and I've never had an issue like this before.

Expected Result:
It should download and display the rightful ruler of the Mushroom Kingdom properly!

Screenshots

(Plus brownie points to you if you can guess with game I'm referencing)

Platform Info

Windows 10 Pro N, all updates
Pixel XL, so latest Android
Signal, latest beta on both.

Link to Debug Log

https://debuglogs.org/0f99f00de67f668be1136096219f248f079b0edbc5b3f61555593094331ed661
Sent message number: 1551447888495
Received message number: 1551447892871

[scottnonnenberg-signal]

Sadly, that message will never download, because of a race condition. It looks like we updated the message twice at the same time, once from that attachment download, and another from an incoming delivery receipt for that message:

INFO  2019-03-01T13:44:54.234Z GET https://whispersystems-textsecure-attachments.s3-accelerate.amazonaws.com/<snip> 200 Success
INFO  2019-03-01T13:44:54.246Z Worker job 189 (arrayBufferToStringBase64) succeeded in 0ms
INFO  2019-03-01T13:44:54.274Z SQL channel job 2846 (saveUnprocessed) succeeded in 28ms
INFO  2019-03-01T13:44:54.275Z queueing envelope 8281f3fd-f3f5-40b0-8295-9088bdbbb534
INFO  2019-03-01T13:44:54.275Z received unidentified sender message
INFO  2019-03-01T13:44:54.756Z SQL channel job 2849 (createOrUpdateSession) succeeded in 98ms
INFO  2019-03-01T13:44:54.757Z delivery receipt from +[REDACTED]323.1 1551447888495
INFO  2019-03-01T13:44:54.782Z Worker job 190 (arrayBufferToStringBase64) succeeded in 0ms
INFO  2019-03-01T13:44:54.783Z SQL channel job 2851 (removeUnprocessed) succeeded in 27ms
INFO  2019-03-01T13:44:54.807Z SQL channel job 2852 (getMessagesBySentAt) succeeded in 28ms
INFO  2019-03-01T13:44:54.807Z SQL channel job 2853 (updateUnprocessedWithData) succeeded in 26ms
INFO  2019-03-01T13:44:54.808Z SQL channel job 2854 (saveMessage) succeeded in 47ms
INFO  2019-03-01T13:44:54.839Z SQL channel job 2855 (saveMessage) succeeded in 54ms
INFO  2019-03-01T13:44:54.930Z SQL channel job 2856 (removeAttachmentDownloadJob) succeeded in 116ms

And so, the delivery receipt won.