Signal-desktop: left-click on system tray icon should show/hide the window

[knarrff]

• [X] I have searched open and closed issues for duplicates

Bug Description

A left-click on the system tray icon used to bring up / close the Signal window. Since a recent update, it instead shows a small window with two options: 'Show/Hide' and 'Quit'. A right-click produces the same behavior, and there it is expected. A left-click on the other hand typically opens/closes the respective windows directly.

Steps to Reproduce

1. Start signal with tray icon enabled
2. left-click on tray icon to open/close signal window

Actual Result:
Intermediate window with option to quit signal, in addition to the option that would be expected immediately.

Expected Result:
Immediately open/close signal window, depending on current state. No extra menu, requiring extra clicks.

Platform Info

Signal Version: signal-desktop 1.19.0 amd64

Operating System: Debian stable (9)

[SourceBoy]

This is currently a bug in Electron 3 & 4 for Debian (and likely other Linux distros) and not signal-deskop itself.

The click event on Tray is ignored; it always shows the tray's context menu. (UpstreamChangeNeeded)

[knarrff]

Right, given the pointer, I found this:

https://github.com/electron/electron/issues/14941

Now, given that this is quite a serious regression, was it now known when signal decided to upgrade the version of electron it uses? After all, in this case signal isn't using Debian's version of 'electron', but bundles it's own, and as such, can choose the version. Maybe signal should revert to electron v2 for the time being, as this also isn't the only problem with newer versions of electron (speaking of https://github.com/signalapp/Signal-Desktop/issues/2971).

[SourceBoy]

While it'll be unlikely that signal-desktop will go back to Electron 2, perhaps it may make sense to maintain 2 separate branches with one of them locked at 2 if there's enough demand, but this would require backporting changes (and deal with few incompatible APIs), and certain new features may not be available.

[knarrff]

https://github.com/signalapp/Signal-Desktop/issues/2971 seems to be fixed in 1.20

[je-vv]

@knarrff, not quite. I'm using 1.20, and I just started to get the left click only opening, but not closing. But to be honest, prior to 1.20, I was using 1.19 with electron 3.0.13, and now with Signal 1.20 I'm using electron 3.1.1.

[Daedalon]

Can confirm that still on 1.33.3, Windows 10 and --start-in-tray, left click on tray opens but is not able to hide the main window.

[baj0k]

Anything new regarding this bug? Does anyone know if future electron release would fix this?

[je-vv]

If electron issue 14941 is the one, as pointed out by @knarrff, then that's still unresolved.