Shopsys: non-standard version restrictions in composer.jsons

Created on 10 Jan 2019  路  4Comments  路  Source: shopsys/shopsys

What is happening

We have the rules that all external dependencies in composer.json files are defined using caret carsion (^), and internal dependencies can be defined as dev-master. See https://github.com/shopsys/shopsys/blob/master/docs/contributing/guidelines-for-dependencies.md.
However, there are dependencies on shopsys/jparser and shopsys/postgres-search-bundle that do not satisfy these rules. These dependencies are reported by ValidateRequireFormatInComposerJsonReleaseWorker during our release process.

Expected result


Dependencies on shopsys/jparser and shopsys/postgres-search-bundle should be defined the standard way or mentioned in "Exceptions" section in guidelines-for-dependencies.md

Most helpful comment

Well, there is no reason not to have version constraint ^0.1 for both of them. Even though the libraries will not be maintained.

All 4 comments

if this is true then it is strange that snc/redis is not reported
https://github.com/shopsys/shopsys/issues/549

We are not planning to maintain these dependencies, so I vote for Exceptions

Well, there is no reason not to have version constraint ^0.1 for both of them. Even though the libraries will not be maintained.

Less exceptions... ok :+1:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ondrejbohac picture ondrejbohac  路  3Comments

boris-brtan picture boris-brtan  路  5Comments

vitek-rostislav picture vitek-rostislav  路  4Comments

TomasLudvik picture TomasLudvik  路  4Comments

boris-brtan picture boris-brtan  路  4Comments