Shopsys: order of routers priorities

Created on 24 May 2019  路  4Comments  路  Source: shopsys/shopsys

What is happening

FriendlyUrlRouter has a higher priority than basic Router - this might cause potential performance problems as the friendly urls are looked up in a database.

Expected result

FriendlyUrlRouter has the lowest priority in DomainRouter

Performance

Most helpful comment

I totaly agree with change priorities. Basic router should be more priority then FriendlyUrlRouter... I admit that the original routers priority values were written by me and I thought that a smaller number meant a higher priority.

All 4 comments

Doesn't this have a reason? Eg. to provide possibility to override basic or localized router by friendly url?

This issue has been automatically marked as stale because there was no activity within the last 4 months (and it is quite a long time). It will be closed if no further activity occurs. Thank you for your contributions.

I totaly agree with change priorities. Basic router should be more priority then FriendlyUrlRouter... I admit that the original routers priority values were written by me and I thought that a smaller number meant a higher priority.

1653 closed this issue

Was this page helpful?
0 / 5 - 0 ratings

Related issues

boris-brtan picture boris-brtan  路  4Comments

henzigo picture henzigo  路  4Comments

vitek-rostislav picture vitek-rostislav  路  4Comments

vitek-rostislav picture vitek-rostislav  路  5Comments

boris-brtan picture boris-brtan  路  3Comments