Shopsys: composer.json - use patches instead of forks

Created on 21 Aug 2018  路  2Comments  路  Source: shopsys/shopsys

What is happening

Using forks as dependency in composer.json is very slow and maybe even cause need to authenticate yourself on github

Expected result

Use patches instead.

Most helpful comment

I was about to write similar issue into "stable requirements". Temp commit-locks like these are fine for development

https://github.com/shopsys/shopsys/blob/6d6772f34ef4cab096c6029141b22428859836a0/composer.json#L97

https://github.com/shopsys/shopsys/blob/6d6772f34ef4cab096c6029141b22428859836a0/composer.json#L108

https://github.com/shopsys/shopsys/blob/6d6772f34ef4cab096c6029141b22428859836a0/composer.json#L142

But they make install time into insanse times and causes bugs like https://github.com/TomasVotruba/shopsys-spryker-and-sylius-analysis/pull/16#issue-209768449

E.g. this package https://github.com/ddmaster/PostgreSearchBundle is just 5 files that can be easily integrated to Shopsys core.

There is also another hacky solution - patches - https://pehapkari.cz/blog/2017/01/20/jak-snadno-a-rychle-upravovat-soubory-ve-vendoru/ but it can be broken the same way conflicts break merges. I prefer fast and safe approach and use own code or stable version.

All 2 comments

I was about to write similar issue into "stable requirements". Temp commit-locks like these are fine for development

https://github.com/shopsys/shopsys/blob/6d6772f34ef4cab096c6029141b22428859836a0/composer.json#L97

https://github.com/shopsys/shopsys/blob/6d6772f34ef4cab096c6029141b22428859836a0/composer.json#L108

https://github.com/shopsys/shopsys/blob/6d6772f34ef4cab096c6029141b22428859836a0/composer.json#L142

But they make install time into insanse times and causes bugs like https://github.com/TomasVotruba/shopsys-spryker-and-sylius-analysis/pull/16#issue-209768449

E.g. this package https://github.com/ddmaster/PostgreSearchBundle is just 5 files that can be easily integrated to Shopsys core.

There is also another hacky solution - patches - https://pehapkari.cz/blog/2017/01/20/jak-snadno-a-rychle-upravovat-soubory-ve-vendoru/ but it can be broken the same way conflicts break merges. I prefer fast and safe approach and use own code or stable version.

The patches were a pretty unstable solution, the Composer installation was sped up using proper package forking instead (by publishing the fork on Packagist and using Composer replace config, see #490).

Was this page helpful?
0 / 5 - 0 ratings

Related issues

boris-brtan picture boris-brtan  路  4Comments

Miroslav-Stopka picture Miroslav-Stopka  路  4Comments

TomasLudvik picture TomasLudvik  路  4Comments

vitek-rostislav picture vitek-rostislav  路  4Comments

vitek-rostislav picture vitek-rostislav  路  4Comments