@snorfalorpagus, here you go:
Should throw a traceback or warning when attempting to interpolate a point along a LINESTRING EMPTY
object, but instead crashes the kernel.
.png
end of issue report)# python shapely_interpolate_segmentation_fault.py
import faulthandler
faulthandler.enable()
from shapely.geometry import Point, LineString
test_line = LineString(((0,0), (1,1), (2,1)))
print(test_line)
empty_line = test_line.parallel_offset(10., side='right')
print(empty_line)
empty_line.interpolate(.5, normalized=True)
$ python shapely_interpolate_segmentation_fault.py
LINESTRING (0 0, 1 1, 2 1)
LINESTRING EMPTY
Fatal Python error: Segmentation fault
Current thread 0x000000010ce7f5c0 (most recent call first):
File "/Users/user/miniconda3/envs/py3_at1866/lib/python3.6/site-packages/shapely/linref.py", line 22 in __call__
File "/Users/user/miniconda3/envs/py3_at1866/lib/python3.6/site-packages/shapely/geometry/base.py", line 777 in interpolate
File "/Users/user/miniconda3/envs/py3_at1866/lib/python3.6/site-packages/shapely/impl.py", line 37 in wrapper
File "shapely_interpolate_segmentation_fault.py", line 9 in <module>
Segmentation fault: 11
conda
Hm, there is a exceptNull decorator but it does not seem to be used a lot. Might be perfect here?
https://github.com/Toblerity/Shapely/blob/master/shapely/geometry/base.py#L160
https://github.com/Toblerity/Shapely/search?q=exceptnull&unscoped_q=exceptnull
@kannes I think the excepNull
decorator is the right thing to use. Do you want to submit a PR?
@snorfalorpagus @kannes I can submit the PR. Would it simply be adding the exceptNull
decorator to interpolate
?
+ a simple unit test
OK. I will try to get it submitted today.
Sent with GitHawk
Most helpful comment
Hm, there is a exceptNull decorator but it does not seem to be used a lot. Might be perfect here?
https://github.com/Toblerity/Shapely/blob/master/shapely/geometry/base.py#L160
https://github.com/Toblerity/Shapely/search?q=exceptnull&unscoped_q=exceptnull