The function I pass to genid to create the session id is the result of an async call to our backend - it would be nice if genid could work with async functions, as I can't seem to find a way around this!
benheymink
All 9 comments
Yes, indeed. It's similar to https://github.com/expressjs/session/issues/52 but more concise on what I want to do. It would not be easy to make this a backward-compatible change, so it may need to wait to the next major.
Also, just remember, your session IDs should never be something like an auto-incrementing integer :)
dougwilson
on 9 Dec 2014
+1
maxpain
on 17 Sep 2018
+1
michelcve
on 25 Feb 2019
+1 ^ 10
armenr
on 29 Apr 2019
@armenr Your comment isn't super helpful - are you in favour of the proposed change? Or unimpressed with the folks adding thier expression of support?
benheymink
on 29 Apr 2019
@benheymink - I was being a baby. :) I'm definitely in favor of this. Thanks for all the work you guys do to build and maintain the tools we use and love. I was just being bitchy.
armenr
on 29 Apr 2019
@dougwilson Hey Doug, if I may be so frank, is this still on your radar? It's been 5 years, so I thought I'd just ask ;-)
michelcve
on 29 Apr 2019
Someone should submit a pull request.
dougwilson
on 29 Apr 2019
@dougwilson You mean, fix the merge conflicts in PR 121, or is that one no longer valid?
michelcve
on 30 Apr 2019
Related issues
gk0us
路
18Comments
aheyer
路
15Comments
fibo
路
22Comments
azfar
路
14Comments
Matthew-Christopher
路
27Comments
Most helpful comment
Someone should submit a pull request.