Serving: We need a common repo for sharing common libraries

[mattmoor]

Surfacing an old email thread here to increase visibility.

tl;dr I'm wondering about the utility of creating an github.com/knative/pkg repository to hold generally useful packages in a shared place.

You can see some precedent for this in places like:

• github.com/coreos/pkg: CoreOS owned useful libraries,
• github.com/pkg: Someone even created an org around the "pkg/" convention.

This is an extension of this style guideline.

I'm thinking here about our use of multiple repositories, and how we share logic across them, especially as this grows. An alternative to this is a mono-repo, but I think that sends the wrong message wrt the coupling of knative components.

I think the most contentious aspect is the name, so if folks have alternatives please add them here, and let the bikeshedding begin :)

cc @vaikas-google @evankanderson

[n3wscott]

+1000 for /pkg

[josephburnett]

-999 for /pkg to normalize @n3wscott's vote.
+1 for me.

[ImJasonH]

I'm more interested in discussing and enumerating the packages that would end up in a shared repo than in the name of that repo (renaming is pretty easy, we have practice :) )

(knative/pkg is fine by me, though)

• common logging - build/pkg/logging is copied ~verbatim from serving/pkg/logging
• webhook controller - build/pkg/webhook is largely copied from serving/pkg/webhook; standardizing how objects are validated/defaulted would help a lot
• integration test harness: build's e2e tests are limited, and I'd love to steal use serving's e2e test infrastructure

Others?

[n3wscott]

there is some framework we can abstract from creating and running the reconcile controllers as well.

[mattmoor]

@ImJasonH What I had in mind:

• pkg/configmap
• pkg/logging
• pkg/webhook
• pkg/controller (though I think I'd like to wait for https://github.com/knative/serving/issues/1505)
• pkg/controller/testing ?
• pkg/signals ?

[n3wscott]

@mattmoor yes!! and they don't all have to go in at one time

[mattmoor]

@n3wscott I'd rather they go in one at a time :)

[dewitt]

I've created the knative/pkg repo.

Admins are the Knative admins group and a new Pkg admins group containing @mattmoor.

Bots and hooks still need to be set up.

This may be sufficient to close out this issue, but let me know if you need anything more!

[mattmoor]

Thanks @dewitt !