Service-catalog: refactor kubeconfig loader into `pkg/util/kube`

[MHBauer]

See https://github.com/kubernetes-incubator/service-catalog/pull/2158 for some history of this code.

Right now code in pkg/svcat/ is relied upon by the apiserver and the e2e tests. It's not hurting anything as it is, but it could be put into a better place.

Tasks for completing this issue:

• [x] Move the code from pkg/svcat/kube/kube.go to pkg/util/kube/kube.go and fixup all the imports.
• [ ] Bonus points for finding other uses of go-client/tools/clientcmd and making them use this common kubeconfig loader.

This is probably 2 serial PRs worth of work.

/good-first-issue

[k8s-ci-robot]

@MHBauer:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

See https://github.com/kubernetes-incubator/service-catalog/pull/2158 for some history of this code.

Right now code in pkg/svcat/ is relied upon by the apiserver and the e2e tests. It's not hurting anything as it is, but it could be put into a better place.

Tasks for completing this issue:

• [ ] Move the code from pkg/svcat/kube/kube.go to pkg/util/kube/kube.go and fixup all the imports.
• [ ] Bonus points for finding other uses of go-client/tools/clientcmd and making them use this common kubeconfig loader.

This is probably 2 serial PRs worth of work.

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Bubblemelon]

@MHBauer Hello. I'm interested in getting this done :smile:

And you mean client-go/tree/tools/clientcmd instead of go-client ?

[MHBauer]

@Bubblemelon go for it. you can have it. the clientcmd thing looks correct. I just wrote this off the top of my head.
Good Luck We're here to help.

[Bubblemelon]

Hello @MHBauer :smile:

For clarity on item 2 in the to do list, are you suggesting to find other projects that might want to utilize go-client? Could you elaborate on this task?

Thanks!

[Bubblemelon]

CC: @carolynvs

[carolynvs]

Sorry I'm not quite sure what @MHBauer was hinting at with the second point?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten