Service-catalog: svcat sync broker message is misleading

[carolynvs]

When I sync/relist a broker using svcat, what is really happening under the hood is bumping the relist request field. However the message printed by svcat says "Successfully fetched catalog entries from the NAME broker" which implies that the sync has already occurred.

It would better set expectations if the message where something like "Synchronization requested for broker: NAME". ~Perhaps a --wait flag could be added that would wait until sync occurs and succeeds or fails?~

• --wait is out of scope of this issue, I'll split that out into a new one.

[pmorie]

Sounds like a good idea.

[teaguecole]

I will work on this.

[carolynvs]

The current message is "Successfully fetched catalog entries from the %s broker" which is incorrect. The message should be "Synchronization requested for broker: %s".

When someone runs svcat sync broker FOO, the svcat client sends an async request to service catalog asking for the broker to be synced, but the sync takes a while. So right now it's confusing because you see that message and really the sync isn't done and you won't see new classes/plans for a bit.

[teaguecole]

Ah, sorry, I just caught myself.

[teaguecole]

Done, I want to go through the walk through/run the code and see the pretty new message. Obviously this will work, and its not a major change, but I will treat this as if it is since its my first PR for Kubernetes. Expect pull request this evening.

[teaguecole]

How do I mark this as closed as the PR has been approved, merged and closed?

[duglin]

I assume you mean this PR: https://github.com/kubernetes-incubator/service-catalog/pull/1979 right?

Put:

Closes #1979

in the first comment of the PR next time and github will auto-magically close the issue when the PR is merged.

[duglin]

Closing - fixed in https://github.com/kubernetes-incubator/service-catalog/pull/1979