Server: Login UI bug with button (alt-login)
hello there. I found a login page UI bug about alt-login button:
my version is 16.0.4 stable
but I found it same in the new versions:
that I thing we should changed to
<input type="submit" class="login primary" formaction="<?php print_unescaped($login['href']); ?>" value="<?php p($login['name']); ?>" />
(I used formaction for can not to change the js file. but it maybe not work if not support to html5 tags status)
maybe we should put it all in <input> not a <a> link. what's U think?
befor:
fix:
evil7
All 5 comments
cc @skjnldsv @GretaD
kesselb
on 24 Sep 2019
This has been changed in 18 already.
What is the exact issue, I don't get your explanation :)
skjnldsv
on 24 Sep 2019
Sry I means can't alignment. The button in login page are diff width. And it's only 16.0.4 now at (free) stable version not 18 (maybe it already fixed in Pro 18 version?) I just think we should fix it at 16 version unless all latest update is 18 now :P
evil7
on 24 Sep 2019
17 is the next major release.
18 means the current development branch.
There is no such thing like a pro version. Feel free to submit a patch with your changes. Should be a few lines of css. I don't think we need to replace the a with an button.
kesselb
on 24 Sep 2019
Yeah. Fix it whatever way I think is all OK. I just don't wanna send a PR just for this "1 line" UI problem. And if it's already being fixed at 18 then plz just close this issue. And thx for this awesome file-cloud project again. <3
evil7
on 24 Sep 2019
Related issues
MorrisJobke
路
3Comments
ghost
路
3Comments
brylie
路
3Comments
Django-BOfH
路
3Comments
mfechner
路
3Comments
Most helpful comment
17 is the next major release.
18 means the current development branch.
There is no such thing like a pro version. Feel free to submit a patch with your changes. Should be a few lines of css. I don't think we need to replace the a with an button.