Server: Show expiration date on receiving shares

[skjnldsv]

• [ ] Android @tobiasKaminsky
• [ ] Desktop @camilasan
• [ ] iOS @marinofaggiana
• [x] Server
• [ ] Server Email
  On the expiration date, we could show a message stating how many time is left.

[MorrisJobke]

For internal shares this should go into the sidebar right? For the public shares it should be at a similar location as the note already is or do you have a better idea?

[skjnldsv]

I was indeed thinking about user shares, like having a small calendar/time icon and a popup with the remaining time :)
No idea on the public shares! @nextcloud/designers ?

[jancborchardt]

Would agree with @MorrisJobke this should go in the sidebar if anything. And for public shares it should also go into the to-be-added sidebar (for comments etc).

[skjnldsv]

Something like that? :)

[jancborchardt]

Ah ok, you mean for the sender?

In that case it should either be a subline (like the "Connect items to a project …" is for "Add to a project") or the icon should overlay the 3-dot menu so when you click, the relevant controls are opened. (Or both.)

[skjnldsv]

Nono, the mockup is wrong since it comes from the sender part, you're right.
I mean for the receiving share :)

[jancborchardt]

Ok, then how about my suggestion above for the sender part, and this for recipient:

[skjnldsv]

Awesome! :+1:

[tobiasKaminsky]

This should then also be done on clients, or?

[skjnldsv]

Ideally yes

[skjnldsv]

[tobiasKaminsky]

I think it should either be
"expires in 18 days" as in "Folder xy share expires in 18 days"
or
"will expire in 18 days" as in "Folder xy share will expire in 18 days"

[tobiasKaminsky]

BTW: how do you get the 18 days info?

[skjnldsv]

[tobiasKaminsky]

hm.
Can't we have "shared_with_me" query somewhere in propfind?
We do only need expiration, ownerId and owner display name.
Later two are already there.

This way we could omit a new query…

[jancborchardt]

@skjnldsv just nitpicks:

• "Expires" with -s and capital E. "Expires in 4 days"
• The subline should have text color maxcontrast so it’s not so present as the text above.

[skjnldsv]

@jancborchardt fixed already (after the screenshot ;) )

[wiswedel]

Related: https://github.com/nextcloud/server/issues/15680

[marinofaggiana]

hm.
Can't we have "shared_with_me" query somewhere in propfind?
We do only need expiration, ownerId and owner display name.
Later two are already there.

This way we could omit a new query…

true ... where we can find the expiration date ?

[skjnldsv]

true ... where we can find the expiration date ?

look at the content of the screenshot above

[marinofaggiana]

yes, true, but would be more correct in propfind near

"<owner-id xmlns=\"http://owncloud.org/ns\"/>" "<owner-display-name xmlns=\"http://owncloud.org/ns\"/>"
?

[tobiasKaminsky]

@skjnldsv the property is not available via dav file query, but only via share endpoint.
On client we want to query this all in once, so it would be very good to have this info also in dav.

[skjnldsv]

@tobiasKaminsky that's a different issue ^^

[tobiasKaminsky]

Indeed: https://github.com/nextcloud/server/issues/16967

[skjnldsv]

https://github.com/nextcloud/server/pull/15719 is merged, go go go Clients :D