Server: Sync (Push) notifications

[tobiasKaminsky]

Done

• [x] Android
• [ ] iOS
• [ ] Desktop
• [x] Server

When receiving a notification:

On Android/iOS:

• you get a push notification (displayed as popup/ in statusbar)
• you can click on it, get redirected to list of notifications
• on iOS you can delete notifications via swipe (get also deleted on server)

On Desktop:

• polling of notifications

Missing:
iOS @nextcloud/ios:

• [x] "delete" action on push notification is missing
• [x] handle incoming "delete" push notification

Android @nextcloud/android:

• [x] "delete" action on push notification is missing https://github.com/nextcloud/android/pull/3608 https://github.com/nextcloud/android/pull/3606
• [x] "delete" action in notification list is missing https://github.com/nextcloud/android/pull/3607
• [x] handle incoming "delete" push notification https://github.com/nextcloud/android/pull/3969

On server @nickvergessen:

• [x] once a notification is dismissed this should be sent as "deleted" event with id to all devices so they can remove the pending push notification

Desktop @nextcloud/desktop:

• [ ] notifications should be on top
• [x] notifications should be removed once they are dismissed on server https://github.com/nextcloud/desktop/issues/685

[tobiasKaminsky]

• once a notification is dismissed this should be sent as "deleted" event with id to all devices so they can remove the pending push notification

@nickvergessen can I send custom push notifications to me, so that I can test this?

[nickvergessen]

https://github.com/nextcloud/notifications/blob/master/docs/admin-notifications.md

[tobiasKaminsky]

This works really nice:

• send a notification with "delete:$id" as subject
• on receiving a push notification, I first check for delete subject, if not regular notification is shown else I delete the shown notification (if available)

@nickvergessen this is of course only a test and should then be done in a safer way, maybe we can use "app" for this? "delete_notification" as app.
Also this notification then should not be shown/stored at all on server.

(https://github.com/nextcloud/notifications/blob/master/docs/push-v2.md)

[rullzer]

* on receiving a push notification, I first check for delete subject, if not regular notification is shown else I delete the shown notification (if available)

Only delete it if the id matches of course ;)

[marinofaggiana]

Hi, next week I will implement this ... now I am too busy for remake of tab "Media" ...

[tobiasKaminsky]

For receiving "hidden" push messages to delete the notifications on screen, we would need implementation by @nickvergessen.

[nickvergessen]

First marino needs to move iOS to PushKit, otherwise he can not hide/delete notifications, which would mean the delete notifications would also show up

[tobiasKaminsky]

Ah, ok did not know about iOS internals, but on Android we receive a push and then can decide if we want to show a notification.

But then this is step 2 :-)

[marinofaggiana]

Soon !! (next week) @Ivansss ;)

[tobiasKaminsky]

ping @rullzer to have a look into push server side

[nickvergessen]

Why?

[tobiasKaminsky]

@nickvergessen cause you are busy in talk and we wanted to keep work off you.

[tobiasKaminsky]

First marino needs to move iOS to PushKit, otherwise he can not hide/delete notifications, which would mean the delete notifications would also show up

@marinofaggiana have you already switched to PushKit?

[nickvergessen]

Yes, it was done yesterday+today.

However beta2 just went out, i guess we have to wait one more release?

[tobiasKaminsky]

Great to hear :-)
Then we can start implementing it. I guess, @nickvergessen the server/app has to start, or? :tada:

[tobiasKaminsky]

Re-opening as this is missing on desktop (sync without push) and iOS.

[MorrisJobke]

Re-opening as this is missing on desktop (sync without push) and iOS.

cc @camilasan @marinofaggiana