Server: Share indicator on file list

[tobiasKaminsky]

• [ ] Android @tobiasKaminsky
• [x] iOS @marinofaggiana
• [ ] Server @nextcloud/server-triage

I am about to add avatar icon to shares, same like on web ui.

first is within the same server, second is via federated share:

Android:

web UI:

Now some questions to discuss:

• why is federated sharing on web ui not done via avatar? Generation of remote avatars should be possible?
• how to handle space problem on mobile? show "shared"? Same for federated sharing? show beginning of userId?
• how to distinguish between "local" avatar and remote/federated one?

@nextcloud/designers
@marinofaggiana

[marinofaggiana]

Good but this (for me) is too "heavy" for a small phone ... no ?

[skjnldsv]

@jancborchardt I think we can remove the avatar and only keep the share icon?
What do you think? :)

[tobiasKaminsky]

Removing the avatar is in my opinion the wrong way, as we have this currently on android.
And then you cannot distinguish if you have shared a file or if it a received share.

[skjnldsv]

Maybe just use the avatar then?

[tobiasKaminsky]

@marinofaggiana they then seem to be missing on the folder.
On android/web ui you can also click on these icons and the sharing view opens directly.
(that is the reason why the are always visible, as they are a shortcut to the sharing dialog).

[marinofaggiana]

Sorry I remembered badly ..... now I have look the code ...

[jancborchardt]

• If there's no avatar yet for any scenario, it's just because no one implemented it yet. We should move to avatars everywhere, not only for the share owners. (We specifically moved _to_ avatars because icons are bland and not informative @skjnldsv :)
• We don't show the text "Shared" anymore, the faces imply sharing. We should cut the share icon too when shared.
• It's not necessary to distinguish between local and federated avatars in that small list.
• It should be limited to 3 avatars, overlapped. Ideally the most recently active people on that share (if possible to get that info).

What do you think?

[skjnldsv]

(We specifically moved to avatars because icons are bland and not informative @skjnldsv :)

So you agree we could get rid of the sharing icon then? :)

[tobiasKaminsky]

• If there's no avatar yet for any scenario, it's just because no one implemented it yet. We should move to avatars everywhere, not only for the share owners. (We specifically moved _to_ avatars because icons are bland and not informative @skjnldsv :)

:+1:

• It's not necessary to distinguish between local and federated avatars in that small list.

:+1:

• We don't show the text "Shared" anymore, the faces imply sharing. We should cut the share icon too when shared.
• It should be limited to 3 avatars, overlapped. Ideally the most recently active people on that share (if possible to get that info).

This applies to shares that we create and share with e.g. 2-5 users.

--> I am fine with these ideas.
What about the others?

[marinofaggiana]

for me is not good, too much video games or social network , I think that is not a util information

[tobiasKaminsky]

@jancborchardt what do you think?
@marinofaggiana I think these are crucial informations and an avatar icon is far better than a generic share icon, in my opinion.
Of course these screenshots look a bit crowded with avatars, but in reality you do not share this much…

[marinofaggiana]

@tobiasKaminsky @jancborchardt can you imagine this screenshot + avatar on an iPhone 5

[tobiasKaminsky]

We have this nearly the same way on web UI:

I really like it as you can see directly from whom the share is…

[marinofaggiana]

I see a lot of chaos ... but @jancborchardt it's the responsible for the UI/UX ... @jancborchardt ?

[tobiasKaminsky]

This is my personal cloud, as you can see there are way less shares.

[jancborchardt]

So you agree we could get rid of the sharing icon then? :)

@skjnldsv yes, see the second bullet point :wink:

We should cut the share icon too when shared.

---

@tobiasKaminsky your screenshot of the app looks great! This is really how we should do it, so clean.

@marinofaggiana yes, I can imagine that. Currently you have a lot of different icons on the folders, but no real info. I can’t quickly find the pictures of our vacation together! But with the faces shown, I can simply find your face. :)

[tobiasKaminsky]

I can’t quickly find the pictures of our vacation together!

Jan and Marino had a vacation together? rumor :rofl:

[marinofaggiana]

Done.

[jancborchardt]

Oooh @marinofaggiana piu magnifico mi fratello!

[tobiasKaminsky]

I am not a UI expert (Jan is), but on Android we have the avatars as big as folder icons, and "share" symbol a bit smaller.

[skjnldsv]

I am not a UI expert (Jan is), but on Android we have the avatars as big as folder icons, and "share" symbol a bit smaller.

yes, 32px for both

[jancborchardt]

@tobiasKaminsky good catch, I was looking at it a bit too closely I guess. :D

[tobiasKaminsky]

yes, 32px for both

Not sure how it is on iOS, but on Android you cannot use absolute pixel, as it depends heavily on screen size & resolution.

[skjnldsv]

Not sure how it is on iOS, but on Android you cannot use absolute pixel, as it depends heavily on screen size & resolution.

Yes, I was referring to how it was on the desktop! You're the experts here ;)