Server: Titles for share pages are not specific
The titles for share pages are missing some info:
- Shared files just show
Nextcloud - Shared folders show
Files - Nextcloud
Instead, we should show the actual names, as we also do in the header:
- The shared file shown above should have
Screenshot from 2018-01-07 00-36-09.png - Nextcloud - The shared folder shown above should have
Screenshots - Nextcloud
It seems the title has to be passed via PHP or so, so cc @nextcloud/sharing
jancborchardt
All 9 comments
I'll take this
sebastiaanspeck
on 3 Oct 2018
Where can I find the php-file where this has to be changed?
sebastiaanspeck
on 3 Oct 2018
Sadly this is partly done in PHP and then also in JS afterwards 馃檲
MorrisJobke
on 3 Oct 2018
Correct me if I'm wrong, but the PHP-function getTitle() has to be changed and the JS-function setPageTitle has to be changed?
has to be changed to use the filename or folder
has to be changed to use the filename or folder instead of files/Files
sebastiaanspeck
on 3 Oct 2018
has to be changed to use the filename or folder instead of files/Files
I would just change the JS side for now. This should be enough.
MorrisJobke
on 3 Oct 2018
Okay, but how can I get the filename/folder? In the screenshot I see the string (fileId?), but how can I convert that to the filename/folder?
sebastiaanspeck
on 3 Oct 2018
Okay, but how can I get the filename/folder? In the screenshot I see the string (fileId?), but how can I convert that to the filename/folder?
Good question. Maybe @skjnldsv has an idea. I thought it is in the data attributes of <html> but it isn't.
MorrisJobke
on 4 Oct 2018
@MorrisJobke I have no idea! :(
@jancborchardt do not put good first issue on stuff that touches the js from files :grimacing: :stuck_out_tongue_winking_eye:
skjnldsv
on 4 Oct 2018
Moved to 16.
MorrisJobke
on 15 Nov 2018
Related issues
blackcrack
路
3Comments
williambargent
路
3Comments
juliushaertl
路
3Comments
mama21mama
路
3Comments
ghost
路
3Comments
Most helpful comment
I'll take this