Server: Download action in share link header split in two

Created on 20 Jun 2018 · 6Comments · Source: nextcloud/server

In the header of sharing, on the top right there’s the download actions:
screenshot from 2018-06-20 13-51-10

Now the design for this (and as it worked before) is:

Both text and 3-dot menu toggle are _one_ element. The text is merely a label for the icon as the actions are all "related" to download (and Download shows in the menu).
The text "Download" is not displayed on mobile to save space for the title of the file, only the 3-dot-menu remains.

As it currently is:

It’s split into "header-primary-action" and "header-secondary-action" which is confusing.
The "Download" text does not vanish on mobile.

Now we could do the following to mix the approaches:

On mobile, only have the 3-dot icon and all actions in the 3-dot menu (primary action first) like in the intended design
On bigger sizes, having the primary action outside of the menu (like in the current way)
To make it less confusing, on desktop we need to make obvious that there’s a primary button, so we should probably add a white border (a la button style) around the text.

What do you think @juliushaertl @skjnldsv @nextcloud/designers?

3. to review bug design sharing regression

Source

jancborchardt

Most helpful comment

On mobile, only have the 3-dot icon and all actions in the 3-dot menu (primary action first) like in the intended design

:+1:

To make it less confusing, on desktop we need to make obvious that there’s a primary button, so we should probably add a white border (a la button style) around the text.

That sounds like a good approach. @nextcloud/designers

juliushaertl on 27 Jun 2018

👍3

All 6 comments

Is this causing issues actually? Or is it just a nitpick to improve the design?

skjnldsv on 26 Jun 2018

On mobile, only have the 3-dot icon and all actions in the 3-dot menu (primary action first) like in the intended design

:+1:

To make it less confusing, on desktop we need to make obvious that there’s a primary button, so we should probably add a white border (a la button style) around the text.

That sounds like a good approach. @nextcloud/designers

juliushaertl on 27 Jun 2018

👍3

Ah yes, I did not understand the issue like that!
I'm all in as well :)

skjnldsv on 27 Jun 2018

@juliushaertl yep, like that! :) But on bigger widths, the "Download" action then does not need to be in the 3-dot menu too when it’s already shown outside of it. Otherwise, want to open a pull request for it?

jancborchardt on 17 Jul 2018

👍1

@jancborchardt @skjnldsv Moved to 15