Server: Comments with mentions look broken in the comments view

Created on 23 Apr 2018  Â·  4Comments  Â·  Source: nextcloud/server

Activity view

bildschirmfoto von 2018-04-23 12-33-43

Comments view

bildschirmfoto von 2018-04-23 12-33-47

It seems to be broken, because the author information row uses the same CSS classes as the inline mentions. (width 100%, etc.), see Nextcloud 13 for help how it should look

cc @nextcloud/designers

bug design comments regression

Most helpful comment

Looking at the Riot redesign, the avatars in mentions look pretty great:

Sorry for picking this up again @nextcloud/designers (especially @pixelipo ;) but it seems we just need to find the right adjustment – like with putting a container with slight grey background around the avatar and name – and then it looks great.

All 4 comments

Avatars are going to be removed from mentions in comments (and then I guess that we should remove them from the activity view too) so that should implicitly fix this issue.

Okay, so let's keep this issue, to make sure this gets addressed before we release something.

Looking at the Riot redesign, the avatars in mentions look pretty great:

Sorry for picking this up again @nextcloud/designers (especially @pixelipo ;) but it seems we just need to find the right adjustment – like with putting a container with slight grey background around the avatar and name – and then it looks great.

Fixed by #10288

bildschirmfoto 2018-07-25 um 14 32 01

Was this page helpful?
0 / 5 - 0 ratings