Server: Request: allow comments on one time passwords under Personal Settings
There is currently no way for users to leave comments about one time passwords they've generated within Personal Settings/Security. It would be useful if we could leave comments on our one time passwords, but an optional description field (ideally available upon creation) could also work.
sunjam
All 8 comments
Can I try to work on this issue?
farrahD
on 26 Feb 2018
I am pretty new at this. Could I be pointed in the direction of the file and folder I would be looking in to work on this?
farrahD
on 28 Feb 2018
I've worked on backend changes to the model and controller, and related unit tests. Comments are stored as varchar(250), with truncation at the setter and tests confirm truncation has occurred.
Wanting a good random string to test I used code from StackOverflow with attribution.
Issue 8443 Backend
Shall I PR now or wait for 14 release to finish?
Implemented db changes by hand since I can't find any documentation on a migration generator.
liamdennehy
on 1 Jul 2018
From my POV the app name field should already be fine for that, we should just make sure that the text is editable so additional information can be added for tokens that are added there using the flow auth. cc @nextcloud/designers
juliushaertl
on 2 Jul 2018
Some environments (especially in large organisations) could benefit from being able to add metadata to entries, e.g. documentation, designs, change requests, security waivers etc. I don't think we want to clutter the UI with an overly-large "name" field, though I have only worked on the back-end. This does feel like we should have a more generic metadata/comment/description approach for lots of different Entity types.
liamdennehy
on 2 Jul 2018
PR #10075
liamdennehy
on 2 Jul 2018
From my POV the app name field should already be fine for that, we should just make sure that the text is editable so additional information can be added for tokens that are added there using the flow auth. cc @nextcloud/designers
@juliushaertl should we close this then in favour of #6717
violoncelloCH
on 20 Nov 2018
@violoncelloch Yes, let's go for the editing approach and avoid adding a separate field.
juliushaertl
on 20 Nov 2018
Related issues
jancborchardt
路
3Comments
georgehrke
路
3Comments
MorrisJobke
路
3Comments
williambargent
路
3Comments
mfechner
路
3Comments
Most helpful comment
From my POV the app name field should already be fine for that, we should just make sure that the text is editable so additional information can be added for tokens that are added there using the flow auth. cc @nextcloud/designers