Sentry-cli: [1.52.0] mkdirp 1.0.0 only support node >= 10

Created on 25 Mar 2020  路  5Comments  路  Source: getsentry/sentry-cli

sentry-cli update the version mkdirp to '^1.0.0' in the release of 1.52.0, which is only supporting node >=10. issue

this causes some people can't install in the lower version node.

question

All 5 comments

mkdirp 1.0.0 patched a vulnerability issue described here https://github.com/getsentry/sentry-cli/pull/685 and it's no longer supported by the author:

Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)

See: https://www.npmjs.com/package/mkdirp/v/0.5.4

If you still want to use old version, you can use yarn and force the oldmkdirp version 0.5.4 using selective version resolution - https://classic.yarnpkg.com/en/docs/selective-version-resolutions/

Sentry-cli currently declares that it supports Node.js 8.x though:

https://github.com/getsentry/sentry-cli/blob/6d9ba9f3e3f061839735e986839d8935672e6121/package.json#L52-L54

I think that a better approach would be to downgrade the dependency to ^0.5.4 for the 1.x release line, since upgrading to 1.x is a breaking change (since it drops support for Node.js 8)

Fair enough. Patched here https://github.com/getsentry/sentry-cli/pull/699 and created a separate issue to keep track of it.

How about using make-dir

@aaharu starting node 10, we can just use mkdirSync('', { recursive: true });

Was this page helpful?
0 / 5 - 0 ratings