Sentry-cli: bug: false negative on invalid email

[jef]

Description

Using sentry-cli 1.55.1

Could not determine any commits to be associated with a repo-based integration. Proceeding to find commits from local git tree.
Could not find the previous commit. Creating a release with 20 commits.
error: API request failed
  caused by: sentry reported an error: request failure (http status: 400)
  Object({"commits": Object({"author_email": Array([String("Enter a valid email address.")])})})

Add --log-level=[info|debug] or export SENTRY_LOG_LEVEL=[info|debug] to see more output.
Please attach the full debug log to all bug reports.

When I run a git log, I have an output of regular addresses and even anonymous email addresses. But I believe this is the culprit for given me the above error:

49699333+dependabot[bot]@users.noreply.github.com

Any email address like this I believe will also throw errors:

29139614+renovate[bot]@users.noreply.github.com

Probably because of the square brackets.

Maybe the email should either be ignored or have an option to ignore commits by certain names?

[kamilogorek]

Hey, thanks for opening the issue. Verified it locally and this is indeed the case. However, the problem lies on the server-side, not the CLI itself. We'll discuss internally where to fix it though, as this change has some broader implications to the whole "suspected-commits" system. Cheers!

[jbinto]

Also see https://github.com/getsentry/sentry/issues/20085

[ianks]

Is there a temporary fix in the meantine?

UPDATE:

For a hotfix of our deployment, we are going to do this temportarily. Not ideal, but will at least fix our error tracking / deployment process:

sed -i 's/EmailField/CharField/g' /usr/local/lib/python2.7/site-packages/sentry/api/serializers/rest_framework/commit.py;

[kamilogorek]

Upstream fix PR: https://github.com/getsentry/sentry/pull/20342

[silent1mezzo]

This has been merged and deployed.