Great point @zsck. Tagging this one for 0.4.1. I also wonder if some of the functionality in manage.py could be DRYed up (e.g. both journalist.py and manage.py adds users).
https://github.com/freedomofpress/securedrop/pull/1850/files fixes a race and adds tests for one function. One step toward that goal ;-)
A regression during the work #1509 showed that we need tests for _run_from_commandline for each subcommand because args.func(args) may call a function that "forgets" to accept the CLI args object as the singular argument.
Most helpful comment
https://github.com/freedomofpress/securedrop/pull/1850/files fixes a race and adds tests for one function. One step toward that goal ;-)