Secret-hitler: Chat Lock keeps locking

[NeelApte]

Hey guys, My chat lock keeps locking after an election occurs. Does anyone else have the same problem?

[cozuya]

Hmm yeah noticed some strangeness here, will work on it asap

[cozuya]

Anyone have any reproduction steps here?

[MOZGIII]

Just get in game or lobby. Maybe zoom the page in (that's what I usually do). After new messages arrive chat locks, and can no longer see any new messages.
I propose allowing disabling chat autolocking altogether as a workaround.

[cozuya]

OK I'll see if I can get it to fail and will put a priority on getting a solution in

[andy013]

Hopefully fixed in the PR I put up on bitbucket. Let me know if it's still broken after you push it live.

[cozuya]

Has this been better in 0.10.2?

[MOZGIII]

No, still have the issue

[MOZGIII]

From experience - stuff like this is not easily fixed. Please provide a workaround of some sort for now - I have to manually scroll the chat down all the time, and can't focus on the game.

[andy013]

Thanks for letting us know. I can't repo this bug on my end so I wasn't confident the first fix would do much but I wanted to check before adding more code in if it was unnecessary. It should be fixed in the next update.

[MOZGIII]

For real this time? :)

[cozuya]

@andy013 I haven't seen a commit from you in the last few days so is there some code you think fixes this? Planning bugfix patch tomorrow.

[andy013]

Yeah, I put it in a new branch on bitbucket.

[cozuya]

👍 I'll integrate today. BB doesn't inundate maintainer with email notifications unlike github for whatever reason.

[andy013]

Cool, you should look it over and maybe test it if you are able to repo as I've been pretty busy and didn't spend much time on it.

[cozuya]

I can't reproduce it locally either =/ bug definitely get it on the site. Who knows.

[cozuya]

Any better in 0.10.3?

[MOZGIII]

I played like 2 hours ago. Seems a bit better, but had chat locked once. Might be my bad. Overall better, but I'm sure yet if it's fully resolved.
I'll need to spend some more time before I can confirm.
Could you link the commits here so I see what to look for?

[andy013]

@NeelApte @MOZGIII Any update on this? Are you guys still experiencing this?

[MOZGIII]

Chat locking works as intended now. However I can see other stange effect: when in game, lobby (non-game) chat keeps "rescrolling" to the bottom.
So it kind of slowly scrolls to last message and below, and when done scrolls a bit back and repeats. Even when there're no new messages in that chat it happens.

[cozuya]

That happens for me too but I keep forgetting to call that out. Its been happening since 0.10.0 @andy013 could you take a look? I'm usually on win 10 chrome.

[MOZGIII]

Don't think I've seen it before the locking fix.

[andy013]

Thanks for the update. It's difficult for me to figure this out as it has always worked completely fine for me on both local builds and on the live site. It's very strange.

Just to clarify, this new issue only happens when you have the right sidebar turned on while in a game? Does it matter if you are observing the game or sitting down? Also, does the lock icon change while it's doing this?

[cozuya]

I'll take a video. It happens for me all the time even when I'm just in the lobby. The genchat scrolls up, and then when an update happens it snaps back to the bottom.

[andy013]

Hey, I wanted to let you know I haven't forgotten about this. I have implemented a fix on my local branch that I hope will work. However, right now the code is mixed in with a bunch of other stuff I was working on and I will need to finish that and clean everything up before I can push it. It might take me a little while as I've been pretty busy and I seem to be coming down with the flu now :( . I might also need to wait until the tournament stuff is out so I can merge my changes easier.

Just to let you know that I will put in a PR eventually to address this issue and if it doesn't work I will look into changing to a different scrollbar solution.

[cozuya]

Hey no problem take your time!

[MOZGIII]

For me chat worked as intended today so far. I'd consider issue resolved. The scroll-locking parts works good all the time now. Not sure about that other bug, I didn't have it today too - so looks ok to me.

[DennisTheFinn]

this should be good, no one that I've talked to (~10 peeps) are having issues