Secret-hitler: Production CSS is not being minified correctly

[jbasrai]

The styling bugs seem to stem from a global reset property not being set correctly.

1. The unminified property (semantic.scss -> style-dark.scss):

*,
*:before,
*:after {
  box-sizing: inherit;
}

html {
  box-sizing: border-box;
}

1. After minification in dev (style-dark.css):

*,*:before,*:after{box-sizing:inherit}html{box-sizing:border-box}

1. After minification in prod (s-6-12-2017.css):

:after,:before{box-sizing:inherit}html{box-sizing:border-box}

The *s are just getting lopped off or something, I'm really confused. I think I'll need your help on this one; I couldn't figure out how the prod stylesheet is bundled and why it's dropping important stuff from the source file.

[jbasrai]

Realized that the minifier might be confusing lines starting with asterisks for comments. Attempted a fix but not sure how to test it.

[cozuya]

Wow! Nice catch.. strange. That explains the CSS troubles in profiles huh? So as I've said my build system is incredibly out of date, like ~18 months. The easiest solution would be to jump ship on it and move to webpack. However that is something I was planning on doing towards the end of getting to 1.0. As I said your profile system was the last major piece of work I wanted out, so maybe I can work on that today?

[jbasrai]

Using webpack would be really nice. In the short term I thiiiink my PR should fix the problem, and it's not doing anything too crazy.

[cozuya]

Cool I'll bring it in today. OT sort of but I'd like to get to 1.0 in the next few weeks which to me means "all bugs fixed all desired features in" and this is my current list with "agile story points" in front, any thoughts?

2 look into dead player talking thing
3 font size game setting
3 unit tests
2 clicking on playerlist icon should route you to that game if you're not seated && inprogress
5 build system overhaul
3 react component refactor - stateless && prop-types
5-8 upgrade all dependencies, upgrade ubuntu/node/mongo
2 new UI for private game in leftsidebar
5 look into shuffling of policies less than 3 to see if its done right
2 spec election president should not be able to nominate anyone int he last election
3 announcement feature
3-5 refactor connection/disconnection/userlist add and remove code

[jbasrai]

Looks good to me. I can help with some of this stuff, especially the bug fixes. Is it feasible to set replays as a 1.0 goal?

[cozuya]

Do what you feel like! If you want to replays I'll bring it in when its done, there's no freeze on 1.0 so to speak. I'm going to be doing the announcement feature 1st, and then probably get going on webpack.

[jbasrai]

Noticed some changes were released today. Just to clarify, these didn't include the latest styling changes right? I thought my fixes didn't work, but then realized that the styling for the broadcast feature, also in master, wasn't in the latest stylesheet.

[cozuya]

No sorry it was an unofficial patch to bring in new mods, fix "Jazz" and um something else? I plan on a release in the next day or two bringing in this and other updates.

[jbasrai]

Ok cool got it!

[jbasrai]

Not resolved by the patch. I'm inclined to wait for #90 to fix this.

[cozuya]

I changed it to box-sizing border box for everything and it seems to be working. I'm hoping next rlease it works.

[jbasrai]

The only problem I noticed was in-game, both sides of the track are shown:

[cozuya]

hmm thats current master? that's obviously not releasable. browser/os?

[jbasrai]

Ya it's on master.

Chrome v58.0.3029.110
OSX Yosemite v10.10.5

[cozuya]

I can't reproduce on same browser/os. Tried min and non-minned versions. Clear cache? I can't thing of how that could happen. Check out 0.6.2 commit and rebuild and try again?

[jbasrai]

Really weird. I definitely still see it after clearing my cache and updating the branch.

[cozuya]

hmm well while I'm currently on macos and chrome I'm actually on chrome 59 and sierra 10.12. I can't imagine that'd change etc though. Typically you see that stuff due to backface-visibility not being set right, maybe play around with that CSS? Not sure what to do here, I will try it on my windows machine when I get home.

[jbasrai]

And reverting my branch to an early 0.6.2 commit fixes the problem. Now that you mention it, I saw something weird with the backface-visibility property, I'll take another look.

[cozuya]

Well at least its reproducible, I will hold off on 0.6.3 until we figure it out.

[jbasrai]

Should backface-visibility: hidden be applied to both sides of the track? Doing that seems to fix it for me.

[jbasrai]

Moved this comment to another issue

[cozuya]

yeah if you can fix it with re-applying backface visibility thats fine. Is that in your current PR? If so, I will do some quick review tomorrow morning and include it in 0.6.3 which I wasn't planning on doing but would be awesome to get out tomorrow as well. If you have some time, would you like to update the changelog/page-home patch notes? I'd include that gif obv. If not I can do it, but its of course your baby.

[jbasrai]

It's not included, but I'll drop it in with the changelog updates and get it prepped for tomorrow 👍