Scratch-www: teacher registration form has two different font weights

Created on 29 Jul 2019  路  9Comments  路  Source: LLK/scratch-www

go to https://scratch.mit.edu/educators/register:

"Create a Username" and "Password" have two different font weights!

image

help wanted mini

All 9 comments

Note a few things:
a) The font weights are actually specified differently:

.row label {
    font-weight: 500;
}
b, strong {
    font-weight: bold;
}

And the elements are different:

<div class="username-label"><b>Create a Username</b></div>

for the username and

<label class="control-label col-sm-3" data-required="true" for="frc-user.password--1310671131">Password<span class="required-symbol"> *</span></label>

for the password.
b) The difference is even more pronounced on my system, Chrome 75.0.3770.142 Windows 10 OS Version 1809 (Build 17763.615), where I don't have the site's preferred fonts:
image
c) Looking at the HTML for the password label, there's a <span class="required-symbol"> *</span> there... doesn't show up at all. Should this be in a separate issue?
d) Description paragraph before the form is missing a space:
image
This is because there's literally no space here in the HTML:

...one day.</span><b><span>Please...

Fix by adding a nbsp. Should this be in a separate issue?

@Kenny2github wrote:

Should this be in a separate issue?

Yes, feel free to create it!

and thanks for the research, this will help fix it! Feel free to submit fixes for these -- seems like it should be fairly straightforward, now that you've looked into it!

@ascii I'm taking the liberty of tagging this "help wanted" because it's a small change, and @Kenny2github added helpful context. (Please LMK if that's not the right thing to do!)

@benjiwheeler I take it you meant to ping @thisandagain? :P

@benjiwheeler I take it you meant to ping @thisandagain? :P

Oops, yes, wrong username for this platform! cc: @thisandagain

Issues I asked whether to open separate issues for are now separate issues, #3213 and #3214.

I believe I've solved the issue. PR is here: https://github.com/LLK/scratch-www/pull/3482

Fixed by #3482

Was this page helpful?
0 / 5 - 0 ratings