Scratch-www: Firefox - Text overflow on credits page

[thisandagain]

The contributor lists don't fit on the cretis page, because line breaks are being blocked.

My browser / operating system: Windows 7, Firefox 55.0, Flash 26.0 (release 0)

Posting this here so I won't have to bother with image hosting for the screenshot ;)

---

Moved from LLK/scratch-flash#1344
/cc @gunchleoc

[TheGrits]

I'll take a shot at this one!

[thisandagain]

Thanks @TheGrits !

[TheGrits]

I tried adding <div>s around the words+comma combos to make sure that they don't get separated... but then they all float to the right. 🤔

I'm currently working a day job for the summer, so I may not fix this in a prompt manner. If someone else wants to take a shot at this one, go for it!

[thisandagain]

@TheGrits No problem! Thanks for giving it a shot.

[Petroochio]

I think I've got it. There is a global style

p a {
  white-space: no-wrap;
}

This appears to be causing the issue. I can disable it with .credits p a { white-space: normal; }

[gunchleoc]

Shouldn't the white-space: normal be a property of p rather than a?

I think a cleaner fix would be to have a special no-wrap style for places where no wrapping is allowed, wrapping is what one would expect normally, after all. I don't know the code base though.

[Petroochio]

@gunchleoc I think I agree with you, but I wasn't sure where changing a global style like that would cause issues in a project this large. To me it would seem less common to want no-wrap, but I was afraid of regression issues.

[gunchleoc]

Since that global style is asking for more trouble down the line, maybe possible regressions right now before even more pages are converted to the new format would be the lesser of 2 evils?

Of course, I'm not a coder on this project, so we'd best leave that decision to somebody who knows the project well.