Scratch-www: Offline editor download page: top paragraph not centered

Created on 27 Jun 2017  Â·  10Comments  Â·  Source: LLK/scratch-www

When the download page is displayed in a wide window, the paragraph at the top of the page ("You can install the Scratch 2.0 editor....") is aligned left and wrapped to an unnecessarily narrow column width.

Note that this problem existed on the old page, but IMO stands out more on the new version of the page.

Screenshot:
image

design

Most helpful comment

@jwzimmer Thank you, I understand the issue much more clearly now!

I don't have time to fix it at present, but may try to fix it at a later point.

Hey @St19Galla maybe you would be interested in tackling this help-wanted issue?

All 10 comments

@cwillisf

This was purposefully done to match the design of other newly migrated pages, such as the Educators and Developers pages.

Another option could be to implement the plainer design used by the info pages, such as the FAQ page.

The Educators & Download pages seem to behave differently at smaller widths, and there seems to be padding to the left of the Scratch logo in the navbar that isn't present to the left of the text at the top of the Download page.

Educators page is centered at small-ish width:
screen shot 2017-06-29 at 10 17 35 am

Educators & Download pages at the same widths:
screen shot 2017-06-29 at 10 17 13 am
screen shot 2017-06-29 at 10 16 30 am

Lack of padding next to the text:
screen shot 2017-06-29 at 10 15 09 am

@jwzimmer Thank you, I understand the issue much more clearly now!

I don't have time to fix it at present, but may try to fix it at a later point.

Hey @St19Galla maybe you would be interested in tackling this help-wanted issue?

@jwzimmer I feel like I'm seeing that padding misalignment on both pages, including Download – it looks like the logo is not being spaced out all the way to the edge of the box in all cases on that size of a screen.

As for the text on the download page taking up 100% – @carljbowman I think in our typography/global stylings we have text take up 100% on mobile. Should we consider standardizing a margin at that screen size, given that this is not the first time we're looking into this? Or do we just want to treat this as another exception to that rule?

I'll try this

Ok, created a pull request ^^

Agreed with @mewtaylor that we probably need to normalize / standardize the rules here regarding when to center and assigning a standard margin for mobile (rather than the awkward spacing we have now). Until this is decided I'm going to remove "help-wanted".

offtopic question, @cwillisf why is the navbar orange?

I think it’s because it’s a testing/development version they’re using.

@DeleteThisAcount as @VutonDesign said - our testing environment has an orange navbar so we can easily see if we're on the staging server or the live site.

Was this page helpful?
0 / 5 - 0 ratings