Scout: Scout, ranklista, comments

Created on 4 Sep 2019  Â·  8Comments  Â·  Source: Clinical-Genomics/scout

Hej
jag föreslÄr att det finns en visuell skillnad mellan "comments" i Variantlistans rank-rutan beroende pÄ om kommentaren Àr global eller lokal.
mvh

enhancement Customer Request Easy

All 8 comments

Hi, just to clarify, you mean this list for instance?

image

Do you have any suggestion?

Correct!

Maybe different color, but from your picture I can see that “hoovering” over it displays that info.

For me, it would make sense to discriminate by eye from local and global. Not sure what other users think?

FrÄn: Chiara Rasi notifications@github.com
Skickat: den 11 september 2019 11:13
Till: Clinical-Genomics/scout scout@noreply.github.com
Kopia: HÄkan Thonberg hakan.thonberg@sll.se; Author author@noreply.github.com
Ämne: Re: [Clinical-Genomics/scout] Scout, ranklista, comments (#1302)

Hi, just to clarify, you mean this list for instance?

[image]https://user-images.githubusercontent.com/28093618/64684246-0ae48c80-d485-11e9-8862-9bfdb93fdd71.png

Do you have any suggestions?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Clinical-Genomics/scout/issues/1302?email_source=notifications&email_token=ALIHQ4SZB2WFHSE7IPZVW4LQJCZDHA5CNFSM4ITPXEHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6N2O2I#issuecomment-530294633, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALIHQ4SACSS6KRVGCSJERU3QJCZDHANCNFSM4ITPXEHA.

Different colours for the bubble?

On 11 Sep 2019, at 11:18, 47KW notifications@github.com wrote:

Correct!

Maybe different color, but from your picture I can see that “hoovering” over it displays that info.

For me, it would make sense to discriminate by eye from local and global. Not sure what other users think?

FrÄn: Chiara Rasi notifications@github.com
Skickat: den 11 september 2019 11:13
Till: Clinical-Genomics/scout scout@noreply.github.com
Kopia: HÄkan Thonberg hakan.thonberg@sll.se; Author author@noreply.github.com
Ämne: Re: [Clinical-Genomics/scout] Scout, ranklista, comments (#1302)

Hi, just to clarify, you mean this list for instance?

[image]https://user-images.githubusercontent.com/28093618/64684246-0ae48c80-d485-11e9-8862-9bfdb93fdd71.png

Do you have any suggestions?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Clinical-Genomics/scout/issues/1302?email_source=notifications&email_token=ALIHQ4SZB2WFHSE7IPZVW4LQJCZDHA5CNFSM4ITPXEHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6N2O2I#issuecomment-530294633, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALIHQ4SACSS6KRVGCSJERU3QJCZDHANCNFSM4ITPXEHA.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Or a different shape of the bubble if there are global comments ?

After discussion in the office, this is maybe a non-issue since we are avoiding making global comments in general
😊
Suggest to leave it as it is

/ HÄkan

FrÄn: Valtteri Wirta notifications@github.com
Skickat: den 11 september 2019 11:22
Till: Clinical-Genomics/scout scout@noreply.github.com
Kopia: HÄkan Thonberg hakan.thonberg@sll.se; Author author@noreply.github.com
Ämne: Re: [Clinical-Genomics/scout] Scout, ranklista, comments (#1302)

Different colours for the bubble?

On 11 Sep 2019, at 11:18, 47KW <[email protected]notifications@github.com> wrote:

Correct!

Maybe different color, but from your picture I can see that “hoovering” over it displays that info.

For me, it would make sense to discriminate by eye from local and global. Not sure what other users think?

FrĂ„n: Chiara Rasi <[email protected]notifications@github.com>
Skickat: den 11 september 2019 11:13
Till: Clinical-Genomics/scout <[email protected]scout@noreply.github.com>
Kopia: HĂ„kan Thonberg [email protected]hakan.thonberg@sll.se>; Author <[email protected]author@noreply.github.com>
Ämne: Re: [Clinical-Genomics/scout] Scout, ranklista, comments (#1302)

Hi, just to clarify, you mean this list for instance?

[image]https://user-images.githubusercontent.com/28093618/64684246-0ae48c80-d485-11e9-8862-9bfdb93fdd71.png

Do you have any suggestions?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Clinical-Genomics/scout/issues/1302?email_source=notifications&email_token=ALIHQ4SZB2WFHSE7IPZVW4LQJCZDHA5CNFSM4ITPXEHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6N2O2I#issuecomment-530294633, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALIHQ4SACSS6KRVGCSJERU3QJCZDHANCNFSM4ITPXEHA.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Clinical-Genomics/scout/issues/1302?email_source=notifications&email_token=ALIHQ4THA6EVSUSJ3BHZEADQJC2DHA5CNFSM4ITPXEHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6N3GYA#issuecomment-530297696, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALIHQ4S4ICO3RXN2EVJWRQTQJC2DHANCNFSM4ITPXEHA.

Ah ok, it was an easy fix :)

A globe if global and a 
.map if local
😉

FrÄn: Chiara Rasi notifications@github.com
Skickat: den 11 september 2019 11:26
Till: Clinical-Genomics/scout scout@noreply.github.com
Kopia: HÄkan Thonberg hakan.thonberg@sll.se; Author author@noreply.github.com
Ämne: Re: [Clinical-Genomics/scout] Scout, ranklista, comments (#1302)

Or a different shape of the bubble if there are global comments ?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Clinical-Genomics/scout/issues/1302?email_source=notifications&email_token=ALIHQ4WLTLPFIKJKEYBZHBDQJC2TNA5CNFSM4ITPXEHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6N3TWQ#issuecomment-530299354, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALIHQ4SYEXS7G4WVMQ3NRDLQJC2TNANCNFSM4ITPXEHA.

What about adding the globe if there are global comments and leaving the comment bubble as it is if it's local?

image

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ViktorHy picture ViktorHy  Â·  4Comments

hassanfa picture hassanfa  Â·  3Comments

heronikdin picture heronikdin  Â·  4Comments

dnil picture dnil  Â·  3Comments

moonso picture moonso  Â·  4Comments