Safe-react: Spending limits: the spending limit never expires

[liliya-soroka]

Title/Description

the spending limit is never expires .
I have create some of the spend limits quite a long time ago and all of them ( even with 1 day, or 1 time) are still available for using
I have used only Rinkeby for testing.

Environment

• Browser: Chrome
• Safe: 0x1230B3d59858296A31053C1b8562Ecf89A2f888b
• Wallet: MM
• App Version: 3.6.0
• Environment:
  
  
  
  • staging (rinkeby)
  
  
  • PR # https://pr2246--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x1230B3d59858296A31053C1b8562Ecf89A2f888b/transactions
  
  

Steps to reproduce

1. Check spending limits table
   Current result:

2. There is one-time spending limit that was already used once

3. Go to send funds
4. Connect allowed awner from the spending limit

5. select the currency from the spend one time limit
   Current result: The spending limit is available as an option for the fund sending

6. send max allowed value

7. try to send the same token again
   Current result: spending limit is again allowed as an option and I can send funds as allowed owner without any time limitations

Expected result

the spending limit option should not be available on the "send funds" form after reset time
Maybe it also makes sense to add some UI difference in the spending limits table between the active limits and expired limits
Also, it would be nice to see a real date instead of Monday 4:56, because it's the same information all the time and it;s not clear was it expired or not

Obtained result

the spending limit option should not be available on the "send funds" form after reset time

Screenshots

[rmeissner]

The reset time is more a "renew time". So at that point in time your allows is "reset" to its initial value, meaning you have the full allowance available again.

This timestamp is not an "expiration date"

[tschubotz]

yea, I think is working as expected

• "reset time" is actually a "renewal time"
• "one time" means just that it want renew. It can be consumed with as many txs as you want. As long as the sum of it stays below the limit.

Closing this then.