Safe-react: Argent wallet prod issues

[francovenica]

1 -
URL: https://gnosis-safe.io/app/#/safes/0xB7526726EE1031AF7d700B0351EE5a20dd910177/transactions

Tried signing with a tx that requires 2 owners
I Created a tx with the Argent wallet user and a regular signature was shown for me, that asked me for a fee (instead of just sign the off chain tx)

$4.80!!!

After signing the Tx was created but got stuck in pending.

In that account at the moment I only had $2.4 dls (0.01eth) but I don't think that's the issue since it seems Argent gives you a few free-fees for your first txs.

The address of the wallet I'm using: 0xDd7F1Ae5bF375F65f3Abf6e90A0556f570Edf44A
safe address: 0xB7526726EE1031AF7d700B0351EE5a20dd910177

2 - I tried to create a safe with the argent account, but I always failed in the step 4 or 5.
This are the failed tx's
https://etherscan.io/tx/0xe77e8ebd6494cdbb92b3fc1d901882949d81600efdadbd3940e2b667b3df99e8
https://etherscan.io/tx/0xe635e2ef0385fc63a00c0cb0f2658a8c7a1e9ee6c18edbef2bc79b717fd9c8df

3 - I created a safe with an MM account and had the argent account as co-owner, 2 signatures needed
https://gnosis-safe.io/app/#/safes/0x160236A11f81858F2179db1F80f9353785349903/transactions

I changed req confirmations and signed first with the MM account, then with the Argent account.
A notification poped up that it failed. But the change in the settings when through

0x4a10603cdab5b426b2e99a1fe51e95e38a2c06cb0f79ded42fd4392a548d7e68

Then I changed the settings again, now only 1 signatures was required and I did it with the Argent account. Again a notification poped up saying that it failed, but it actually went through

0x5d082d82d065f2431bc29f75525bee862d3d7bba84a6273a69c4dac6329fbd16

At any point was charged in the Argent account, but I think Argent gift you a few "Fee-free" tx when you create an account.

[mikheevm]

Argent is a smart contract wallet and smart contract wallets do not support offchain signatures

[lukasschor]

Probably related with #887 and likely a general issue with all smart contract - based wallets (Dapper, Authereum, legacy Safe Mobile App, Argent)

[Agupane]

So after doing some research we analyzed the cases 2) and 3), we didn't try to reproduce it 1) because It would lock our Safe and wasn't necessary after the results of 2) and 3).

Results of 1) (Safe Creation):

• We got a transaction failed error, after debugging it using tenderly, we found that there is a problem with the Argent Wallet, the transaction errored with this message:

Error Message: execution reverted
require(checkAndUpdateUniqueness(_wallet, _nonce, signHash), "RM: Duplicate request");

Results of 3) (Signing/Executing a transaction):

• On the console we got an unprocessable entity error from the backend, but if you see the result of the tx it was successful and the operation was confirmed (please check the tx with id 4 on the safe)

This is the data that we sent to the backend and failed:

baseGas: 0
contractTransactionHash: "0x5116d309913558216bc10238ee40ff8c8b2b2cbc8a98f7b753d1987213d46ca3"
data: "0x"
gasPrice: "0"
gasToken: "0x0000000000000000000000000000000000000000"
nonce: 2
operation: 0
origin: null
refundReceiver: "0x0000000000000000000000000000000000000000"
safeTxGas: 27845
sender: "0xA4F7cEfA69473B7ED3719B2b6C1504C909eC793e"
to: "0x1a3D4Fa6934703FdEfd3215e735CC4Cf38503203"
transactionHash: "0x4dda86ff6a8bf0931d666619741c650fc7a24c733ecb913ecf905b5b33fba3bb"
value: "1000000000"

• But if we analyze the tx hash that's confirmed and executed (0xf65b94ac91bd0fcd300ff98da10efaaca3b54ec9f0a61d0366170c24ba1cbfdb) seems to be different from the errored one: 0x4dda86ff6a8bf0931d666619741c650fc7a24c733ecb913ecf905b5b33fba3bb

This is the Safe we used: 0xd8Cb50Dc901521DA34980D1D6E8cB150E81b26C6 it's totally a new-one safe

This is the Argent wallet we used: 0xA4F7cEfA69473B7ED3719B2b6C1504C909eC793e

I think we should need to open an issue to the Argent team so they can check this out because the error appears to be on their side, especially because of this error:

Error Message: execution reverted require(checkAndUpdateUniqueness(_wallet, _nonce, signHash), "RM: Duplicate request");

CC: @fernandomg @mikheevm @lukasschor @rmeissner

[mikheevm]

@Agupane good job on the research :)

[Agupane]

As this was moved to the Argent Team, I'll move this to the icebox until we got news from new. In case you guys think that this should be on a different column, feel free to adjust it

[rmeissner]

@Agupane did we ever hear back from them?

[Agupane]

Nope I didn't have any news from them @rmeissner

[tschubotz]

Closing this one as it's waiting for Argent

[liliya-soroka]

Updates for the history in case of questions about the signing with Argent in the feature:
22.04.2021 the signing with Argent wallet was retested and there are the results:
Lukas has tested for:
Initiate with Argent
Initiate with Metamask -> approve with Argent
Initiate with Metamask -> approve + execute with Argent
Result: signing works