Rusoto: Decide whether to wait for tokio reform

Created on 7 Feb 2018  路  6Comments  路  Source: rusoto/rusoto

The first piece of the tokio reform was just released: https://tokio.rs/blog/2018-02-tokio-reform-shipped/

At this point, however, neither futures, nor mio or hyper have had the chance to release updates that align them with the new tokio crate.

The blog post hints at more changes to happen within the next 6-8 weeks.

We should observe how the situation develops, and decide whether we want to ship 0.32.0 for the "old" or the new tokio ecosystem.

Most helpful comment

I suppose so, yeah.

As long as we can try to push out a release soon after the changes to future and hyper are released, that should be okay (I'm keen to drop the "custom" default reactor in rusoto for the new one in tokio).

Is this what we can record as the outcome here?

  1. we will not wait for futures 0.2 (and associated hyper 0.12) before releasing Rusoto 0.32.0
  2. we will call out clearly in the README that Rusoto 0.32.0 is not compatible with the new tokio crate

All 6 comments

I think we should release as-is to crates.io. The master branch has proven very usable with tokio-core and hyper 0.11. I would like to avoid cloning down the big rusoto repo in my build env!

It would be considerate to add a note in the README so folks know that the 0.32.0 code is _not_ tokio reform ready but will be soon.

Likewise, I think the changes from tokio reform will be a lot of dependency shuffling and a minor amount of setup code changes, no big changes in how the libraries work. It is good to get this work out there and just inform folks that it's a stepping stone.

I am still not up to speed on tokio, let alone the tokio reforms done and changes coming, but waiting six weeks for another release is a bit long for my tastes.

Would a README note as suggested above be enough notice about Rusoto's use of tokio and friends?

I suppose so, yeah.

As long as we can try to push out a release soon after the changes to future and hyper are released, that should be okay (I'm keen to drop the "custom" default reactor in rusoto for the new one in tokio).

Is this what we can record as the outcome here?

  1. we will not wait for futures 0.2 (and associated hyper 0.12) before releasing Rusoto 0.32.0
  2. we will call out clearly in the README that Rusoto 0.32.0 is not compatible with the new tokio crate

When can we cut a new release?

Here's the list of issues that are part of the 0.32 milestone: https://github.com/rusoto/rusoto/milestone/3

@srijs Those two items look right to me. 馃憤

Was this page helpful?
0 / 5 - 0 ratings

Related issues

matthewkmayer picture matthewkmayer  路  5Comments

softprops picture softprops  路  6Comments

srijs picture srijs  路  6Comments

jonhoo picture jonhoo  路  5Comments

matthewkmayer picture matthewkmayer  路  4Comments