Rpcs3: Vulkan: Possible PR #6357 Regression

[darkash]

build 8534 has black bar upon save point prompt

RPCS3-8534.zip

build 8531, no black bar

RPCS3-8531.log.gz

Operating System:
Windows 10 build 1903
Ram: 8 GB
CPU: i7-8550U
GPU: Nvidia Geforce MX130

Additional Note:
I tried removing all cache and deleting config.yml as well as custom config and the issue still persists.

You might notice that both have different fps counters, but both has been using the same config I generated from build 8534, and if u checked through log both vblank is still default value, so I have no idea why one of them has the fps unlocked somehow while older version locked it to 57 fps and even dips for me.

[Asinin3]

Be sure to tag the Pull Request in the description/comment as well so the developer see's it like so: https://github.com/RPCS3/rpcs3/pull/6357 It doesn't work if you just put it in the title.

[kd-11]

Need RSX capture from the 'good build'

[darkash]

affirmative, will be doing that once I'm home from work.
In the meantime, I will need to know how to enable/do that. Will appreciate if someone point it out to me, thanks :D

[RainbowCookie32]

On RPCS3 go to View, and click Show debugger. Now you have the debugger open on RPCS3's window. Run the game and when you have the issue on screen, click RSX Capture on the debugger. The capture should be saved to captures in RPCS3's folder, you can compress it which usually reduces its size considerably

[Realmantik]

Tales of Vesperia Regressed too after #6357.
build 8351 RSX Capture
v0.0.6-e863fc55 rsx_volatile RSX Capture
v0.0.6-8534-dca29def RSX Capture

[kd-11]

Come on guys, please add screenshots. I don't really know what any of these games are supposed to look like ingame, which means its easy to miss bugs.

[Realmantik]

No matter Vulkan or OpenGL.

[stride21]

Killzone 3 regressed with this PR as well but when using RSX capture it would crash the majority of the time but luckily I got one of the PR, I hope its correct. I still haven't been able to get a RSX capture of the previous build but I can keep trying later if its necessary.
Before:

After:

RSX Capture

[kd-11]

I'm pretty sure these are all one bug (blit engine). I'll push a fix soon.

[darkash]

Here, the RSX capture from last "good build" for me

BLUS30639_20190821015340_capture.zip
RPCS3.log.gz

Thanks in advance :)

[kd-11]

I genuinely wonder if this is better with the text overflowing out of the prompt box.

[kd-11]

Fixed by https://github.com/RPCS3/rpcs3/pull/6376

[Realmantik]

The bug with half screen in Tales of Vesperia is not fixed.

[kd-11]

But I just pushed the code a few minutes ago.

[kd-11]

Looks like there is a regression in MSAA code, I'll push a fix shortly.

[kd-11]

Fixed now.

[darkash]

I genuinely wonder if this is better with the text overflowing out of the prompt box.

you can blame NISA for that lol

anyway, I will test the PR once I got home again, thanks for the hard work!

[Realmantik]

Yes, it is fixed. Cool. Great work!

[darkash]

confirmed it to be fixed with PR #6376 , many thanks

will close this issue now since it's been merged to master as well