Rpcs3: Regressions caused by #5315

[kd-11]

Tracker for any issues caused by https://github.com/RPCS3/rpcs3/pull/5315.
Identified issues so far:

• [x] Some users have significantly reduced performance in some Rachet & Clank titles.
• [ ] Some AMD cards have performance regressions in some applications.
• [x] OpenGL renderer has worse performance in some applications.
• [x] Null renderer is broken.

[digtal-devil]

Ninja Gaiden Sigma freezes on the main menu while the music plays in the background.

Log

[Dani1977]

hi
Demon's souls crash on nexus
RPCS3.zip

[isshininu]

RPCS3.log.gz

Found unusual bug - image in DeS could become black for 1-2 frames, like write color buffers was disabled.

[Kravickas]

U can try deleting shader cache, i had problems with old cache in pr.
For example Ninja gayden works for me.

[altiereslima]

Reduced performance in Minecraft (R9 390, Vulkan Driver 2.0.55)

5372

RPCS3.log.gz

5379 or #5315 RSX always at 99%

RPCS3.log.gz

[kd-11]

This is that AMD thing I mentioned in the post above. Will investigate.

[altiereslima]

This is that AMD thing I mentioned in the post above. Will investigate.

Thank you, kd-11

[kd-11]

@isshininu Duplicate of https://github.com/RPCS3/rpcs3/issues/4857? Afaik the white flickering was fixed but the black flickering remains. Its not trivial to fix it and it occurs somewhat rarely. Will be fixed separately once the new texture cache changes are merged.

[kd-11]

@altiereslima Can you gather a list of affected applications when using AMD+Vulkan? It would be nice to have some more comparison data since 1 game is not enough of a sample size. Also, check how OGL was affected by the changes. I have noted some performance loss on AMD vulkan, but still not enough for the profiler to show any usable differences.

[isshininu]

I cleared all cache and didn't see any more black flickering.
By the way, Demon's Souls perfomance on Vulkan in lower than on OpenGL now, especially sound stutters that were introduced in #5315
It looks like each "RSX: Fault in uninterruptible code!" line breaks background SFXs.

[altiereslima]

@altiereslima Can you gather a list of affected applications when using AMD+Vulkan? It would be nice to have some more comparison data since 1 game is not enough of a sample size. Also, check how OGL was affected by the changes. I have noted some performance loss on AMD vulkan, but still not enough for the profiler to show any usable differences.

Only Minecraft was affected using AMD+Vulkan.
OpenGL increase 30% in Minecraft.
OpenGL increase 2-4 fps in other games.

[kd-11]

So OGL is actually faster but vulkan performance dropped? Very strange indeed. Are you using the same executable name for both? Just in case of application profiles conflicting use the same exe location with the same name.

[kd-11]

@isshininu The log spam has been removed in my branch, will be submitted in a new PR. I realized the excess log activity also breaks DeS for some users with lower end CPUs.

[kd-11]

@Wizzy2018 Need before/after screenshots so that testers can duplicate the exact scenario.

[Dani1977]

hi, i made a clean installation of RPCS3, but emulator keep crash random.

Here an example of crash on training area

RPCS3.zip

[kd-11]

That message does not mean crashing. Its just a diagnostic.

[Dani1977]

this is my event view log:
Il programma rpcs3.exe versione 0.0.0.0 non interagisce più con Windows ed è stato chiuso. Per vedere se sono disponibili ulteriori informazioni sul problema, verificare la cronologia del problema in Sicurezza e manutenzione nel Pannello di controllo.
ID processo: 9bc
Ora di avvio: 01d48a55266ccb72
Ora di chiusura: 5
Percorso applicazione: G:\rpcs3\rpcs3.exe
ID segnalazione: 7ea531f1-2758-4285-a675-3b6791643507
Nome completo pacchetto che ha generato l'errore:
ID applicazione relativo al pacchetto che ha generato l'errore:
Tipo interruzione: Unknown

RPCS3 Hang-on for a minute without response, than crash.
Regards

[Wizzy2018]

@kd-11 i found what was a problem in my case :D After i disabled a SPU loop detection my fps is back to normal and everything works well.
I have a shit cpu i5-4590 :D but it seems its all ok with my RX470 and your build

[Dani1977]

hi,
I clean, spu, ppu and shader cache than I play Demon's souls around 2 hours without a crash.
I change Preferred SPU Threads from auto to 4, a little bit of drops of frames but no freeze and crash.

Regards

edit December 12th.
I start 3 times Demon's Solos, and 3 times in a raw game stuck, then emulator crash:
twice during intro cut scene,
once during pg creation (i clean cache before every time). I try with opengl and vulkan

[cesarnox]

I'm using last master 0.0.5-7539
intel i5 8400 integrated graphics HD 630

vulkan get stuck at this point

if I press X quickly pass this screen and then stuck and the sound continue for a while
RPCS3.log.gz

using OpenGL works and faster than before

graphics issues on OpenGL are not related to #5315

[isshininu]

Duplicate of #4857? Afaik the white flickering was fixed but the black flickering remains. Its not trivial to fix it and it occurs somewhat rarely. Will be fixed separately once the new texture cache changes are merged.

Yep, this is return of old issue. Only on OpenGL renderer - i didn't see this issue on Vulkan yet.

[kd-11]

Oddly, I've always had this DeS issue, it never went away for me ever since I changed my CPU a year ago. So it could just be the different timings manifesting. It warrants investigation on its own.

[digtal-devil]

For example Ninja gayden works for me.

I deleted the shader cache but the game will still hang on the main menu if the Vulkan Renderer is used. I can play NGS if I switch to OpenGL. Oddly enough, the graphics in certain areas have some visual glitches.

[Dani1977]

Hi,
i have update rpcs3 to version v0.0.5-7546 (clean install), but unfortunately i have the same game freeze than emulator crash.
RPCS3.zip

but event viewer is difference than before, now indicate ucrtbase.dll version 10.0.17763.1

this is the event (sorry it is in Italian)

Nome dell'applicazione che ha generato l'errore: rpcs3.exe, versione: 0.0.0.0, timestamp: 0x5c056cc5
Nome del modulo che ha generato l'errore: ucrtbase.dll, versione: 10.0.17763.1, timestamp: 0x309241e0
Codice eccezione: 0xc0000409
Offset errore 0x000000000006f08e
ID processo che ha generato l'errore: 0x3748
Ora di avvio dell'applicazione che ha generato l'errore: 0x01d48b36899300cb
Percorso dell'applicazione che ha generato l'errore: G:\rpcs3\rpcs3.exe
Percorso del modulo che ha generato l'errore: C:\WINDOWS\System32\ucrtbase.dll
ID segnalazione: 92280b90-aa32-41f1-8e9c-567bc3c52514
Nome completo pacchetto che ha generato l'errore:
ID applicazione relativo al pacchetto che ha generato l'errore:

regards

[Daist]

Sacred 2 regressed in PR5315, see below comparison with the previous master:
https://i.imgur.com/MMiCtqy.jpg
PR5391 looks the same as in PR5315.
https://i.imgur.com/BljtISc.jpg

[HenningJW]

@Daist can you post logs?

[Daist]

@HenningJW Sure
7513-RPCS3.log.gz
7536-RPCS3.log.gz
7546-RPCS3.log.gz

[NotUnknownbrackets]

F {rsx::thread} RSX: class std::runtime_error thrown: Assertion Failed! Vulkan API call failed with unrecoverable error: Out of pool memory (VK_ERROR_OUT_OF_POOL_MEMORY_KHR)
(in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vkgsrender.cpp:1058)
RPCS3.log

[LunarisUmbra]

Not sure if this is the proper place to post this, but launching Nier Replicant and selecting 'White Color Buffers' to fix white hue overlay on graphics rendering of the game causes audio stutter that was otherwise not there. If there is something needed like a log or video example I'll be glad to supply it.

P.S. I have version 0.05-7563 of RPCS3 and a clean install
computer Specs:
i7-7700k
GTX 1070
16 gb ram
Win 10

[isJuhn]

R&C ACiT still runs like dogshit after minutes of gameplay on vulkan even after #5391

[psennermann]

Maybe #5515 should be added to this issue...

[kd-11]

Closing meta-tracker, if any regressions are left (Sacred?) open a ticket for them so they can be investigated quickly.