Rpcs3: Missing health bars on Jojo [BLUS31405] on AMD after #4265

[toccata10]

Archlinux, r9 fury, mesa 17.3.7
After #4265, JoJo's Bizarre Adventure: All-Star Battle [BLUS31405] is missing the top bars. It's a known problem for Nvidia, but it used to work fine on AMD. It disappeared both with Ogl and Vulkan.
Comparison screenshots and logs


RPCS3.log-Jojo-OK-6510.gz
RPCS3.log-Jojo-missing-6631.gz

[Asinin3]

This issue is old, not related to that PR AFAIK

[toccata10]

I was disturbed by your comment, so I tested also on Windows 10 (Vulkan), on r9 fury, to narrow down the culprit. The rev6516 is displaying bars, rev6541 is not. So it seems to me it's a new issue, related to the massive #4265.

[Asinin3]

People have been reporting that the health bars go missing since before I joined Discord (August 2017), from what I know, the issue is random and only affects some people. Confirmed to affect both Nvidia and OpenGL as far as I know.

Edit here are some early references I could find:

https://forums.rpcs3.net/thread-174249-post-275022.html#pid275022

[toccata10]

On Rev7104, health bars are still missing.
Now that rpcs3 has a RSX capture tool, maybe it could help get this pb solved:
https://www.dropbox.com/s/7bse8jhghjip7nh/capture-JojoAsb.rrc.zip?dl=0

[oomek]

Any news regarding that issue? It's sad that I can't play that game even though it runs smoothly.

[Canzah]

Issue still present in latest build as of today.

[Fudgecake4567]

I paused and the health bars show up for a brief second, I was wondering if this could help

[SutandoTsukai181]

Commit https://github.com/RPCS3/rpcs3/commit/e8023143 broke the life bars. It's something related to how the game requests depth changes in real time as that's how the life bars work. If you jump you can see your character render in front of the life bar. Trying to directly swap the the old code on latest master made the game crash; needs some proper code.

Also this issue isn't related to AMD, it broke life bars on both AMD and Nvidia on Vulkan. OpenGL was already broken before.

[SutandoTsukai181]

This happened on the build that should be working; life bars are only visible under the light of the corpse parts on the ground.
https://youtu.be/WR6uI0DiZmo

It was working for me just before and I didn't change anything in emu, nor did I update my Nvidia drivers. Also worth noting is that the Farseer build doesn't have life bars on nvidia systems with older drivers (<400)

It probably has something to do with me being on a laptop and hibernating a lot. Either a reboot or a GPU driver update will fix this, but I'm not going to cause this might help fixing the issue for now.

[kd-11]

I ram some hardware tests; both the old code (which worked) and the new code (which doesn't work) are wrong. I'll push out a patch to match hardware behaviour soon.

[kd-11]

Need updated RSX captures to check if its related.

[MANGOPELICAN]

Need updated RSX captures to check if its related.
@kd-11

https://mega.nz/#!niBw1S5Q!IVz8y2ees_tnBxfmyuVvVlnEAVEOgS1DpQJwVo7z2mU
Download link with the RSX Captures

[SutandoTsukai181]

Master and rsx-volatile Captures (different states with one instance where life bars appear):
https://mega.nz/#!GQMCGIQB!cIBHjYd0rIf6Xo_BzbOZLgEUTmNJxnSIjplW8-U8ylM

Will upload renderdoc captures from spu-perf soon, when the life bars were working

EDIT: spu-perf renderdoc captures (lifebars working):
https://drive.google.com/open?id=1o0yO6SGX9Rrxvk9u9fRx8kHnYVA3E0Ar

[SutandoTsukai181]

I didn't specify when exactly did the life bars suddenly appear on master/rsx-volatile, so here are 2 quick videos showing the process on both spu-perf and rsx-volatile:

spu-perf
rsx-volatile(master is the same)

It happens at the end of a specific character's super.

[kd-11]

Its some condition inversion in the shader, I'm running final tests right now.

[kd-11]

Also, even spu-perf was technically broken, not sure why it was working but I'll find out shortly.

[kd-11]

The bug had nothing to do with shaders; its properly fixed with this commit.. The changeset is too large to include in misc fixes PR so you'll have to wait. For builds, see https://ci.appveyor.com/project/kd-11/rpcs3/builds/26835227.

[SutandoTsukai181]

Confirmed working with OpenGL on default settings

Also working with Vulkan, I just had to remove shader cache from the old build and now it's working.
Good job!