Roundcubemail: Add CTRL + Enter shortcut to Send Mail

[gloony]

Hi, I would know if you think it is possible to add a shortcut in TinyMCE for Send mail with CTRL + Enter ?
I already make that on every release since a while, but I think that can be appreciated by some users.
Eventually, give the possibility to change this in settings, to avoid to confuse users whom doesn't want it.

I change this function (on the minified file, so it hard to tell the line)
y=function(){u.shortcuts.add("meta+a",null,"SelectAll");}

By Added
y=function(){u.shortcuts.add("meta+a",null,"SelectAll");u.shortcuts.add("ctrl+13", null, function(){window.parent.$('.button.send').click();})}

[alecpl]

We definitely will not modify TinyMCE. You could try do it in setup function in program/js/editor.js. Anyway I think this calls for some general keyboard shortcuts solution. Some plugins exist already.

[gloony]

Thank you for your quick response.

I understand the will to not modify TinyMCE so I make the modification on file program/js/editor.js.
So I add a new parameter on conf var :

      init_instance_callback: function(editor){
        // Addon to Send Mail with Ctrl + Enter
        editor.shortcuts.add(
            "ctrl+13",
            null,
            function(){
              window.parent.$('.button.send').click();
            }
        );
      }

After my researchs I never found a plugin that add shortcut to TinyMCE (I tried to (re)check all the actual plugins on the offical repo, since your answer).
I would lovely make my own, but it appear to be tricky since TinyMCE want to set is shortcuts at the "init" event.

I let my response here, if somebody need this, in futur (assumed that you must have jQuery on your RoundCube plugins, if your version is lower than 1.4).

[thomas-mc-work]

Wouldn't there be another way to add a shortcut for sending? That would be great!

[Justinzobel]

Agreed, I'd love to be able to set Ctrl+Enter to send as I have in many other mail clients.

[thomas-mc-work]

The latest comment from @gloony looks like a proper way of integration. Wouldn't that be OK for the dev team? Maybe you could prepare that as a PR, @gloony? That'd be great!

[alecpl]

I don't like the idea. So, it will not end up in the core. However, there are some keyboard shortcuts plugins that could be interested in adding this shortcut (if not there yet).

[Justinzobel]

It's fairly core to most other email clients. Do these plugins you speak of
have Github pages where we can suggest this?

On Sun, Apr 26, 2020 at 6:03 PM Aleksander Machniak <
[email protected]> wrote:

I don't like the idea. So, it will not end up in the core. However, there
are some keyboard shortcuts plugins that could be interested in adding this
shortcut (if not there yet).

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/roundcube/roundcubemail/issues/6491#issuecomment-619509606,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKOQBPCJAY4US4IX7TMD63ROPWWZANCNFSM4F6WUXXQ
.

[kiuka]

@alecpl just out of curiosity, why do you not like the idea? Its kind of a standard solution, every single email client, gmail, etc, all support this hotkey by default.

[Edimahler]

Hi guys,
I see it the same way like @kiuka, @Justinzobel and @thomas-mc-work . It wouldn't bother anyone (would it?), but it is a widly known shortcut in most other email programs as well. If you could consider put it to the core, it would be great.