Rofi: [BUG] rofi-git fails to build on Archlinux

Created on 26 Apr 2020  Â·  6Comments  Â·  Source: davatorium/rofi

My C is a tad rusty at the moment, but if pointed in the right direction, I would be happy to take a shot at fixing this.

EDIT: Introduced in commit: https://github.com/davatorium/rofi/commit/151547a99ed142168ec4a11e526102994f6736a9

Steps to reproduce

This snippet assumes you're running Archlinux, and that aur-utils is installed!

$ git clone https://aur.archlinux.org/rofi-git/
$ cd rofi-git
$ aur chroot

The output should be similar to this, with an error here

What behaviour you see

An unsuccessful build

What behaviour you expect to see

A successful build.

Additional details:

bug

Most helpful comment

Should be fixed, please test.

All 6 comments

Can confirm, here's my error

Found ninja-1.10.0 at /usr/bin/ninja
==> Starting pkgver()...
==> Sources are ready.
==> Making package: rofi-git 1.5.4.r102.g151547a9-1 (Sat 25 Apr 2020 06:57:55 PM EDT)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> WARNING: Using existing $srcdir/ tree
==> Starting pkgver()...
==> Starting build()...
ninja: Entering directory `build'
[9/105] Generating source from 'lexer/theme-parser.y'.
../rofi/lexer/theme-parser.y: warning: 1 shift/reduce conflict [-Wconflicts-sr]
[10/105] Generating source from 'lexer/theme-parser.y'.
../rofi/lexer/theme-parser.y: warning: 1 shift/reduce conflict [-Wconflicts-sr]
[11/105] Generating source from 'lexer/theme-parser.y'.
../rofi/lexer/theme-parser.y: warning: 1 shift/reduce conflict [-Wconflicts-sr]
[12/105] Generating source from 'lexer/theme-parser.y'.
../rofi/lexer/theme-parser.y: warning: 1 shift/reduce conflict [-Wconflicts-sr]
[13/105] Generating source from 'lexer/theme-parser.y'.
../rofi/lexer/theme-parser.y: warning: 1 shift/reduce conflict [-Wconflicts-sr]
[15/105] Generating source from 'lexer/theme-parser.y'.
../rofi/lexer/theme-parser.y: warning: 1 shift/reduce conflict [-Wconflicts-sr]
[57/105] Compiling C object 'rofi@exe/source_helper.c.o'
../rofi/source/helper.c: In function ‘cairo_image_surface_create_from_svg’:
../rofi/source/helper.c:1116:9: warning: ‘rsvg_handle_close’ is deprecated: Use 'rsvg_handle_read_stream_sync' instead [-Wdeprecated-declarations]
 1116 |         rsvg_handle_close ( handle, &error );
      |         ^~~~~~~~~~~~~~~~~
In file included from ../rofi/source/helper.c:50:
/usr/include/librsvg-2.0/librsvg/rsvg.h:192:14: note: declared here
  192 | gboolean     rsvg_handle_close  (RsvgHandle handle, GError *error);
      |              ^~~~~~~~~~~~~~~~~
[78/105] Compiling C object 'theme_parser.test@exe/test_theme-parser-test.c.o'
FAILED: theme_parser.test@exe/test_theme-parser-test.c.o
ccache cc -Itheme_parser.test@exe -I. -I../rofi -Isubprojects/libgwater/xcb -I../rofi/subprojects/libgwater/xcb -Isubprojects/libnkutils -I../rofi/subprojects/libnkutils -I../rofi/subprojects/libnkutils/src -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/librsvg-2.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/startup-notification-1.0 -I/tmp/makepkg/rofi-git/src/build -I/tmp/makepkg/rofi-git/src/rofi/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c99 -O3 -Wparentheses -Winline -Wunreachable-code -Werror=missing-prototypes -Wno-inline -pthread -MD -MQ 'theme_parser.test@exe/test_theme-parser-test.c.o' -MF 'theme_parser.test@exe/test_theme-parser-test.c.o.d' -o 'theme_parser.test@exe/test_theme-parser-test.c.o' -c ../rofi/test/theme-parser-test.c
../rofi/test/theme-parser-test.c: In function ‘test_properties_distance_em_fn’:
../rofi/test/theme-parser-test.c:242:22: warning: missing braces around initializer [-Wmissing-braces]
  242 |     RofiDistance d = (RofiDistance){ 1, ROFI_PU_PX, ROFI_HL_SOLID};
      |                      ^
      |                                      {                           }
In file included from ../rofi/test/theme-parser-test.c:46:
../rofi/test/theme-parser-test.c:245:31: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
  245 |     ck_assert_int_eq (  p.left.distance , 10 );
      |                               ^
../rofi/test/theme-parser-test.c:246:30: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
  246 |     ck_assert_int_eq(  p.left.type , ROFI_PU_EM );
      |                              ^
../rofi/test/theme-parser-test.c: In function ‘test_properties_distance_em_linestyle_fn’:
../rofi/test/theme-parser-test.c:258:22: warning: missing braces around initializer [-Wmissing-braces]
  258 |     RofiDistance d = (RofiDistance){ 1, ROFI_PU_PX, ROFI_HL_SOLID};
      |                      ^
      |                                      {                           }
In file included from ../rofi/test/theme-parser-test.c:46:
../rofi/test/theme-parser-test.c:261:38: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
  261 |     ck_assert_double_eq_tol (  p.left.distance , 1.3 , REAL_COMPARE_DELTA );
      |                                      ^
../rofi/test/theme-parser-test.c:262:30: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
  262 |     ck_assert_int_eq(  p.left.type , ROFI_PU_EM );
      |                              ^
../rofi/test/theme-parser-test.c:266:38: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
  266 |     ck_assert_double_eq_tol (  p.left.distance , 1.5 , REAL_COMPARE_DELTA );
      |                                      ^
../rofi/test/theme-parser-test.c:267:30: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
  267 |     ck_assert_int_eq(  p.left.type , ROFI_PU_EM );
      |                              ^
../rofi/test/theme-parser-test.c: In function ‘test_properties_distance_px_fn’:
../rofi/test/theme-parser-test.c:278:22: warning: missing braces around initializer [-Wmissing-braces]
  278 |     RofiDistance d = (RofiDistance){ 1, ROFI_PU_EM, ROFI_HL_DASH};
      |                      ^
      |                                      {                          }
In file included from ../rofi/test/theme-parser-test.c:46:
../rofi/test/theme-parser-test.c:281:38: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
  281 |     ck_assert_double_eq_tol (  p.left.distance , 10.0 , REAL_COMPARE_DELTA );
      |                                      ^
../rofi/test/theme-parser-test.c:282:30: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
  282 |     ck_assert_int_eq(  p.left.type , ROFI_PU_PX );
      |                              ^
../rofi/test/theme-parser-test.c: In function ‘test_properties_distance_px_linestyle_fn’:
../rofi/test/theme-parser-test.c:293:22: warning: missing braces around initializer [-Wmissing-braces]
  293 |     RofiDistance d = (RofiDistance){ 1, ROFI_PU_EM, ROFI_HL_DASH};
      |                      ^
      |                                      {                          }
In file included from ../rofi/test/theme-parser-test.c:46:
../rofi/test/theme-parser-test.c:296:38: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
  296 |     ck_assert_double_eq_tol (  p.left.distance , 10.0 , REAL_COMPARE_DELTA );
      |                                      ^
../rofi/test/theme-parser-test.c:297:30: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
  297 |     ck_assert_int_eq(  p.left.type , ROFI_PU_PX );
      |                              ^
../rofi/test/theme-parser-test.c:300:38: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
  300 |     ck_assert_double_eq_tol (  p.left.distance , 14.0 , REAL_COMPARE_DELTA );
      |                                      ^
../rofi/test/theme-parser-test.c:301:30: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
  301 |     ck_assert_int_eq(  p.left.type , ROFI_PU_PX );
      |                              ^
../rofi/test/theme-parser-test.c: In function ‘test_properties_distance_percent_fn’:
../rofi/test/theme-parser-test.c:312:22: warning: missing braces around initializer [-Wmissing-braces]
  312 |     RofiDistance d = (RofiDistance){ 1, ROFI_PU_EM, ROFI_HL_DASH};
      |                      ^
      |                                      {                          }
In file included from ../rofi/test/theme-parser-test.c:46:
../rofi/test/theme-parser-test.c:315:38: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
  315 |     ck_assert_double_eq_tol (  p.left.distance , 10.0 , REAL_COMPARE_DELTA );
      |                                      ^
../rofi/test/theme-parser-test.c:316:30: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
  316 |     ck_assert_int_eq(  p.left.type , ROFI_PU_PERCENT);
      |                              ^
../rofi/test/theme-parser-test.c: In function ‘test_properties_distance_percent_linestyle_fn’:
../rofi/test/theme-parser-test.c:327:22: warning: missing braces around initializer [-Wmissing-braces]
  327 |     RofiDistance d = (RofiDistance){ 1, ROFI_PU_EM, ROFI_HL_DASH};
      |                      ^
      |                                      {                          }
In file included from ../rofi/test/theme-parser-test.c:46:
../rofi/test/theme-parser-test.c:330:38: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
  330 |     ck_assert_double_eq_tol (  p.left.distance , 10.0 , REAL_COMPARE_DELTA );
      |                                      ^
../rofi/test/theme-parser-test.c:331:30: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
  331 |     ck_assert_int_eq(  p.left.type , ROFI_PU_PERCENT);
      |                              ^
../rofi/test/theme-parser-test.c:334:38: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
  334 |     ck_assert_double_eq_tol (  p.left.distance , 10 , REAL_COMPARE_DELTA );
      |                                      ^
../rofi/test/theme-parser-test.c:335:30: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
  335 |     ck_assert_int_eq(  p.left.type , ROFI_PU_PERCENT);
      |                              ^
../rofi/test/theme-parser-test.c: In function ‘test_properties_padding_2_fn’:
../rofi/test/theme-parser-test.c:981:22: warning: missing braces around initializer [-Wmissing-braces]
  981 |     RofiDistance d = (RofiDistance){ 1, ROFI_PU_PX, ROFI_HL_SOLID};
      |                      ^
      |                                      {                           }
In file included from ../rofi/test/theme-parser-test.c:46:
../rofi/test/theme-parser-test.c:984:38: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
  984 |     ck_assert_double_eq_tol (  p.left.distance , 20, REAL_COMPARE_DELTA );
      |                                      ^
../rofi/test/theme-parser-test.c:985:31: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
  985 |     ck_assert_int_eq (  p.left.type , ROFI_PU_PX );
      |                               ^
../rofi/test/theme-parser-test.c:986:39: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
  986 |     ck_assert_double_eq_tol (  p.right.distance , 20, REAL_COMPARE_DELTA  );
      |                                       ^
../rofi/test/theme-parser-test.c:987:32: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
  987 |     ck_assert_int_eq (  p.right.type , ROFI_PU_PX );
      |                                ^
../rofi/test/theme-parser-test.c:988:37: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
  988 |     ck_assert_double_eq_tol (  p.top.distance , 10, REAL_COMPARE_DELTA);
      |                                     ^
../rofi/test/theme-parser-test.c:989:30: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
  989 |     ck_assert_int_eq (  p.top.type , ROFI_PU_PX );
      |                              ^
../rofi/test/theme-parser-test.c:990:40: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
  990 |     ck_assert_double_eq_tol (  p.bottom.distance , 10, REAL_COMPARE_DELTA );
      |                                        ^
../rofi/test/theme-parser-test.c:991:33: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
  991 |     ck_assert_int_eq (  p.bottom.type , ROFI_PU_PX );
      |                                 ^
../rofi/test/theme-parser-test.c:983:17: warning: variable ‘p’ set but not used [-Wunused-but-set-variable]
  983 |     RofiPadding p = rofi_theme_get_padding ( &wid, "test", pi);
      |                 ^
../rofi/test/theme-parser-test.c: In function ‘test_properties_padding_3_fn’:
../rofi/test/theme-parser-test.c:1001:22: warning: missing braces around initializer [-Wmissing-braces]
 1001 |     RofiDistance d = (RofiDistance){ 1, ROFI_PU_PX, ROFI_HL_SOLID};
      |                      ^
      |                                      {                           }
In file included from ../rofi/test/theme-parser-test.c:46:
../rofi/test/theme-parser-test.c:1004:38: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
 1004 |     ck_assert_double_eq_tol (  p.left.distance , 30, REAL_COMPARE_DELTA);
      |                                      ^
../rofi/test/theme-parser-test.c:1005:31: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
 1005 |     ck_assert_int_eq (  p.left.type , ROFI_PU_PX );
      |                               ^
../rofi/test/theme-parser-test.c:1006:39: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
 1006 |     ck_assert_double_eq_tol (  p.right.distance , 30, REAL_COMPARE_DELTA );
      |                                       ^
../rofi/test/theme-parser-test.c:1007:32: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
 1007 |     ck_assert_int_eq (  p.right.type , ROFI_PU_PX );
      |                                ^
../rofi/test/theme-parser-test.c:1008:37: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
 1008 |     ck_assert_double_eq_tol (  p.top.distance , 10, REAL_COMPARE_DELTA );
      |                                     ^
../rofi/test/theme-parser-test.c:1009:30: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
 1009 |     ck_assert_int_eq (  p.top.type , ROFI_PU_PX );
      |                              ^
../rofi/test/theme-parser-test.c:1010:40: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
 1010 |     ck_assert_double_eq_tol (  p.bottom.distance , 20, REAL_COMPARE_DELTA );
      |                                        ^
../rofi/test/theme-parser-test.c:1011:33: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
 1011 |     ck_assert_int_eq (  p.bottom.type , ROFI_PU_PX );
      |                                 ^
../rofi/test/theme-parser-test.c:1003:17: warning: variable ‘p’ set but not used [-Wunused-but-set-variable]
 1003 |     RofiPadding p = rofi_theme_get_padding ( &wid, "test", pi);
      |                 ^
../rofi/test/theme-parser-test.c: In function ‘test_properties_padding_4_fn’:
../rofi/test/theme-parser-test.c:1021:22: warning: missing braces around initializer [-Wmissing-braces]
 1021 |     RofiDistance d = (RofiDistance){ 1, ROFI_PU_PX, ROFI_HL_SOLID};
      |                      ^
      |                                      {                           }
In file included from ../rofi/test/theme-parser-test.c:46:
../rofi/test/theme-parser-test.c:1024:38: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
 1024 |     ck_assert_double_eq_tol (  p.left.distance , 40 , REAL_COMPARE_DELTA );
      |                                      ^
../rofi/test/theme-parser-test.c:1025:31: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
 1025 |     ck_assert_int_eq (  p.left.type , ROFI_PU_PX );
      |                               ^
../rofi/test/theme-parser-test.c:1026:39: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
 1026 |     ck_assert_double_eq_tol (  p.right.distance , 30 , REAL_COMPARE_DELTA );
      |                                       ^
../rofi/test/theme-parser-test.c:1027:32: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
 1027 |     ck_assert_int_eq (  p.right.type , ROFI_PU_PX );
      |                                ^
../rofi/test/theme-parser-test.c:1028:37: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
 1028 |     ck_assert_double_eq_tol (  p.top.distance , 10 , REAL_COMPARE_DELTA );
      |                                     ^
../rofi/test/theme-parser-test.c:1029:30: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
 1029 |     ck_assert_int_eq (  p.top.type , ROFI_PU_PX );
      |                              ^
../rofi/test/theme-parser-test.c:1030:40: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘distance’
 1030 |     ck_assert_double_eq_tol (  p.bottom.distance , 20 , REAL_COMPARE_DELTA );
      |                                        ^
../rofi/test/theme-parser-test.c:1031:33: error: ‘RofiDistance’ {aka ‘struct <anonymous>’} has no member named ‘type’
 1031 |     ck_assert_int_eq (  p.bottom.type , ROFI_PU_PX );
      |                                 ^
../rofi/test/theme-parser-test.c:1023:17: warning: variable ‘p’ set but not used [-Wunused-but-set-variable]
 1023 |     RofiPadding p = rofi_theme_get_padding ( &wid, "test", pi);
      |                 ^
[91/105] Compiling C object 'theme_parser.test@exe/meson-generated_theme-parser.c.o'
ninja: build stopped: subcommand failed.
==> ERROR: A failure occurred in build().
    Aborting...
Error making: rofi-git

sorry, misread it completely.

Should be fixed, please test.

Confirmed working here.

Thanks.

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

herrsimon picture herrsimon  Â·  5Comments

strogiyotec picture strogiyotec  Â·  4Comments

jluttine picture jluttine  Â·  4Comments

Spindlyskit picture Spindlyskit  Â·  4Comments

digitalphoton picture digitalphoton  Â·  4Comments