Rofi: Can't open programs with termite on version 1.5.3

[digitalphoton]

After updating to version 1.5.3, I am unable to open terminal-based programs with termite using rofi. Downgrading to version 1.5.2 fixes the problem.

Version

Version: 1.5.3

Configuration

gist

Launch Command

rofi -show drun

Steps to reproduce

• Step 1: Ensure that termite is the only terminal emulator installed (otherwise rofi will just use something else)
• Step 2: Launch rofi
• Step 3: Attempt to launch a program that runs on a terminal (like Ranger or Neovim)

What behaviour you see

• Rofi shows the error message "Failed to find a suitable terminal"

What behaviour you expect to see

• The desired program opening in termite

[sardemff7]

It was intentionally removed in 2a93daec0429f0a241687e74740eb73f7f066123 as Termite doesn’t support the default -e command line argument, which broke the default setup when Termite was detected.

Set the terminal option to termite (instead of rofi-sensible-terminal) and it’ll work as expected.

[TheBabu]

I know this issue is closed but it looking the manpage for termite it does support the -e flag? Is it possible for the devs to check if the behavior is expected from termite?

[sardemff7]

It is not up to us to test every single terminal emulator around. If you think Termite was fixed, please test yourself (you can edit the script before installing, or copying it in a $HOME-based bin directory added to your $PATH) and open a Pull Request on Github with all the information, specifically which version of Termite is following the proper -e behaviour.

Reading back the issue that lead to the removal of Termite from the list, it does mention Terminator only, but it could have been a comment on IRC that made Termite go too.

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.