Rocket.chat: Unread bar not showing for livechat room

[tntho]

Description:

The unread bar is not shown when the first unread message out of the screen.

Steps to reproduce:

Visitor send a lot messages.

Expected behavior:

Unread bar (Mark as read bar) should be shown like this

Actual behavior:

Unread bar (Mark as read bar) was not shown and unread messages were marked as read immediately.

Server Setup Information:

• Version of Rocket.Chat Server: 0.71.0

Additional context

It's because of in livechat room case, RoomManager open room by using type + id ( RoomManager.open(type + id) ),
https://github.com/RocketChat/Rocket.Chat/blob/e6d9375fe28abf907577a1e66220d23b6d2027c1/packages/rocketchat-livechat/imports/LivechatRoomType.js#L5-L16

and in readMessages it's using RoomManager.openedRooms[subscription.t + subscription.name]. It makes process not go further to keep unread bar showing.
https://github.com/RocketChat/Rocket.Chat/blob/e6d9375fe28abf907577a1e66220d23b6d2027c1/packages/rocketchat-ui/client/lib/readMessages.js#L125-L128

Why don't livechat room have name property? or should we use room id instead of name to open a room?

[reetp]

Can you please test the on latest 0.72.3

[renatobecker-zz]

Hi @IITNTII.

I'm on our latest version and everything seems to work fine.

[tntho]

I updated issue with picture, what I mean was the unread bar (Mark as read bar) which is shown on the top of room. Thanks

[knrt10]

On it, will try to fix this.

[ashwaniYDV]

@renatobecker I am working on it

[ashwaniYDV]

hi @renatobecker For livechat rooms name property is not defined as @tntho mentioned. Therefore RoomManager.openedRooms[subscription.t + subscription.name] is undefined for livechat rooms. I have fixed this by taking rid in place of name.
Please review #16809

[renatobecker]

The Livechat rooms can't use the name property because there is a unique index for this field and the Livechat rooms use the guest/visitor name to identify the room, so it would be duplicated. Due to that, the Livechat rooms use the fname property instead of the name property, and the same happens to Subscriptions.

Thanks.

[ashwaniYDV]

@renatobecker Got it :+1:
So we have to rely on RoomManager.openedRooms[subscription.t + subscription.rid] instead of RoomManager.openedRooms[subscription.t + subscription.name] for solving this issue because the key for RoomManager.openedRooms in case of livechat rooms is subscription.t + subscription.rid