Rocket.chat: Top navbar in embedded layout mode

Created on 8 Oct 2018  路  7Comments  路  Source: RocketChat/Rocket.Chat

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Previously navbar was removed in embedded mode:
https://github.com/RocketChat/Rocket.Chat/pull/12025/files#diff-e7c838650739eb4cc3317679e1881c6d

However, it is necessary in some cases. Therefore, now we cannot update to the current chat version (in the new versions, important bugs for us have been fixed).

Is it possible to make an extended-embedded layout or another way to activate the top panel in embedded mode?

Additional context
image

challenge easy

All 7 comments

Can you please fill in some more installation details - see the bug template - and refer to the version numbers?
Eg we are using version x and it works. We tested on version y and it doesn't.
Also specify which browsers you have used etc.
Thanks

Can you please fill in some more installation details - see the bug template - and refer to the version numbers?
It's not a bug, it's feature request.
Or do they also need the details you requested?

I think it is a regression if it worked before and doesn't now.

So yes please (it is always worth adding full details regardless of the issue - saves a lot of time when triaging bugs)

Description:

Previously navbar was removed in embedded mode: https://github.com/RocketChat/Rocket.Chat/pull/12025/files#diff-e7c838650739eb4cc3317679e1881c6d

However, it is necessary in some cases. Therefore, now we cannot update to the current chat version (in the new versions, important bugs for us have been fixed).

Is it possible to make an extended-embedded layout or another way to activate the top panel in embedded mode?

See 0.70.0-rc.0 release description:
Hidden admin sidenav on embedded layout (#12025)

Steps to reproduce:

  1. Embed chat to site and open it. (For Example https://open.rocket.chat/channel/general?layout=embedded)

Expected behavior:

I see navbar where I can do things in embed iframe.
Previously, top navbar was always displayed. It would be nice if you had the ability to customize the display for different embeds
image

Actual behavior:

Navbar is hided:
image

Server Setup Information:

  • Version of Rocket.Chat Server: 0.72
  • Operating System: Windows
  • Deployment Method: docker
  • Number of Running Instances: 1

@sdelfi do you want an embedded layout with header right? @reetp its not a regression because now after my changes the code is working as we expected, but I had the same feeling (and missed an extended version)

@ggazzo that's right, it was earlier possible.
Now we use iframe chat in several places and in some we would like to be able to turn it on, and in some - not. If it is, of course, possible to make customizable.

A more flexible solution would be to accept an addition parameter ?layout=embeddedTopNavOn and let that override the setting.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tanc picture tanc  路  3Comments

brendanheywood picture brendanheywood  路  3Comments

engelgabriel picture engelgabriel  路  3Comments

lunitic picture lunitic  路  3Comments

zeigerpuppy picture zeigerpuppy  路  3Comments