Rocket.chat: pruning based on user does not work as intented

[svennd]

Description:

pruning based on @svennd "at user" is removing all messages contrary to what the description says:
"Only prune content from these users (leave empty to prune everyone's content)"

Steps to reproduce:

1. (web interface) -> public channel 3 dots -> prune messages
2. @user_to_delete
3. (optional set time)
4. Prune

Expected behavior:

Remove messages for @user_to_delete

Actual behavior:

remove all messages prior to set time (if this option)

Server Setup Information:

• Version of Rocket.Chat Server: 0.68.0
• Operating System: 4.15.17-2-pve
• Deployment Method: tar
• Number of Running Instances: 1
• DB Replicaset Oplog: disabled
• NodeJS Version: v8.9.3

[vynmera]

Can you take a screenshot? The red box should also say "(if they are from user_to_delete)".

I'll test locally in a moment

[vynmera]

Can confirm it's broken - field is not picked up.

[vynmera]

Looks to be introduced by https://github.com/RocketChat/Rocket.Chat/pull/11236/commits/811b8328c83551bb7f00fce5647c30c2a5e9c103 in a change from using Session to ReactiveVar - not all set operations were updated

[vynmera]

11646 will fix it :tada: