Rocket.chat: [BUG] NEW Custom emojis not working after upgrade in chats.

[kazie]

Description:

After upgrading Rocket.Chat from some version (can't remember exactly sorry, let's call it 0.5.late (about 4 months ago) or 0.6.early to newer ones 0.6.late, at the same time of https://github.com/RocketChat/Rocket.Chat/pull/10171

I was hoping on it getting solved through many upgrades, or that someone else would have the problem (and that I wasn't uniquely having this issue) such that I could comment and add my information to it. But sadly I have not been able to find a ticket that seems to be pointing on the same issue.

I have always given permissions for everyone in the chat to add Emojis, and it has not been a special privilege for users.

Server Setup Information:

• Version of Rocket.Chat Server: 0.65.0 (:latest) (0.69.2 updated 2018-09-18)
• Operating System: Fedora release 24 (Twenty Four)
• Deployment Method(snap/docker/tar/etc): Docker version 17.05.0-ce, build 89658be
• Number of Running Instances: 1
• DB Replicaset Oplog: disabled
• Node Version: v8.9.3(inside docker container)
• mongoDB Version: v3.0.15 (Mongo 3.0 docker container)

Steps to Reproduce:

_This is just a guesstimate, and I am sorry that I do not know exactly if it is reproduceable in this way_

Setup an old setup with rocketchat from:
https://hub.docker.com/_/rocket.chat/
Guessing let's start with 0.60.0.
Upgrade using newer versions.

Migrate to:
https://hub.docker.com/r/rocketchat/rocket.chat/
(because this project was more updated, and thus for us would hopefully solve bugs faster)

See that old added emojis still work.

Try to add new emojis, and try to use them, probably not working?

Expected behavior:

Expected behaviour would be that adding new custom emojis after upgrades would still work, no matter who add them and when they were added.
They should show up in chat as well as they do in the administration view.

Actual behavior:

Adding new pictures works as expected, and are shown in the Custom_emoji administration page.

But when using new emojis, they only show text, in all menus during chat.

But old emojis added ~4-3 months ago before upgrading do work still as intended.

Relevant logs:

(There are no relevant logs)

20180528-15:24:24.123(0) Will load cache for users 
20180528-15:24:24.152(0) 13 records load from users 
20180528-15:24:24.154(0) Will load cache for rocketchat_room 
20180528-15:24:24.161(0) 56 records load from rocketchat_room 
20180528-15:24:24.161(0) Will load cache for rocketchat_subscription 
20180528-15:24:24.192(0) 155 records load from rocketchat_subscription 
20180528-15:24:24.193(0) Will load cache for rocketchat_settings 
20180528-15:24:24.250(0) 678 records load from rocketchat_settings 
20180528-15:24:26.075(0) Updating process.env.MAIL_URL 
20180528-15:24:26.501(0) Starting Email Intercepter... 
20180528-15:24:27.010(0) Will load cache for rocketchat_permissions 
20180528-15:24:27.013(0) 78 records load from rocketchat_permissions 
20180528-15:24:27.018(0) Will load cache for rocketchat_roles 
20180528-15:24:27.019(0) 12 records load from rocketchat_roles 
20180528-15:24:28.903(0) LocalStore: store created at  
20180528-15:24:28.904(0) LocalStore: store created at  
20180528-15:24:28.904(0) LocalStore: store created at  
20180528-15:24:29.435(0) Setting default file store to GridFS 
20180528-15:24:32.971(0) (rocketchat_migrations.js:160) Migrations: Migrating from version 119 -> 121
20180528-15:24:32.973(0) (rocketchat_migrations.js:160) Migrations: Running up() on version 120
20180528-15:24:32.990(0) (rocketchat_migrations.js:160) Migrations: Running up() on version 121
20180528-15:24:33.006(0) (rocketchat_migrations.js:160) Migrations: Finished migrating.
20180528-15:24:43.008(0) Not migrating, control is locked. Attempt 1/30. Trying again in 10 seconds. 
20180528-15:24:43.021(0) (rocketchat_migrations.js:160) Migrations: Not migrating, already at version 121
20180528-15:24:43.662(0) Updating process.env.MAIL_URL 
20180528-15:24:43.718(0) Using GridFS for custom sounds storage 
20180528-15:24:43.724(0) Using GridFS for custom emoji storage 
20180528-15:24:43.728(0) ufs: temp directory created at "/tmp/ufs" 
20180528-15:24:46.136(0) ➔ System ➔ startup 
20180528-15:24:46.137(0) ➔ +----------------------------------------+ 
20180528-15:24:46.138(0) ➔ |             SERVER RUNNING             | 
20180528-15:24:46.138(0) ➔ +----------------------------------------+ 
20180528-15:24:46.139(0) ➔ |                                        | 
20180528-15:24:46.139(0) ➔ |  Rocket.Chat Version: 0.65.0           | 
20180528-15:24:46.140(0) ➔ |       NodeJS Version: 8.9.3 - x64      | 
20180528-15:24:46.140(0) ➔ |             Platform: linux            | 
20180528-15:24:46.141(0) ➔ |         Process Port: 3000             | 
20180528-15:24:46.141(0) ➔ |             Site URL: https://slaptop  | 
20180528-15:24:46.141(0) ➔ |     ReplicaSet OpLog: Disabled         | 
20180528-15:24:46.142(0) ➔ |          Commit Hash: 6d6d8be980       | 
20180528-15:24:46.142(0) ➔ |        Commit Branch: HEAD             | 
20180528-15:24:46.143(0) ➔ |                                        | 
20180528-15:24:46.143(0) ➔ +----------------------------------------+ 

[earlmedina]

I'm not sure if I'm crazy or if this is a related issue. I previously had a rocket.chat server set up and I _swear_ I was able to add custom emojis. With this recent release I'm not seeing the option to upload custom emojis anywhere. Am I missing something?

@kazie I'd love to know how you're adding new emoji as I don't see anything in the UI and I don't recall having to do this on the backend before.

[kazie]

@earlmedina When the "add custom emoji" menu dissapeared for regular users was for us due to this issue: https://github.com/RocketChat/Rocket.Chat/pull/10171 / https://github.com/RocketChat/Rocket.Chat/issues/9865
Which made the administration menu hidden for users, even if they had the special permission for adding emojis.

We did not have to do it through the backend either, but that issue is solved in the latest versions of Rocketchat., whilst our issue (emojis added are not working) doesn't seem like it.
So we are just adding it through the regular administration (three dots) menu. :)

[earlmedina]

@kazie
Thanks for the response. I see - this is not quite what I'm running into? I'm signed in as an Admin, go to Custom Emoji and see nowhere an option to add a new emoji:

[kazie]

@earlmedina ah, for me it is some incredibly small "+" sign to the outmost right of the window. So that would have been about to the right of the rightmost part of the header that says "Custom_emoji".

If you don't have that "+" sign over there that would most probably be a separate bug not related to mine - but an hindrance of uploading custom emojis indeed.

[earlmedina]

@kazie Thank you for confirming your workflow and expected behavior. Have logged issue #10966 for version 0.65.1 accordingly. Seeing this on CentOS 7 (manual install) and Ubuntu 16.04 (snapd).

[kazie]

Updated, still a bug in 0.65.2

[kazie]

Updated, still a bug in 0.66.0.

[sketch242]

For the record, I also still see this with 0.66.0, having done a fresh install a few months ago (0.62.x).

[kazie]

Update as I did upgrade to 0.66.3 and the bug is still affecting this version.

[kazie]

Upgraded to 0.68.0, still affected.

[kazie]

Upgraded to 0.69.1, still affected.

[adam-kulagowski]

We are also hit by this issue onCloud at codilime.rocket.chat (0.69.1)

[kazie]

Upgraded to 0.69.2, still affected.

[FaizanZahid]

we r on latest version, tapping on emo icon on mobile chat on chrome on mobile, just opens nothing. :/

[kazie]

BIG UPDATE
I have actually been able to finally do a root cause analysis for waht caused the bug for us.
So here it is. :)

Someone had inserted an emoji with the character ? in it, all emojis after that stop working, removing said emoji got everything to work again.

I am not sure, but I guess that the code in question can be around here, that would make it stop working? (emoji-custom.js)

Like I said, I have no idea of exactly how in the code it get's bugged. But you can probably analyze it easier now, by know that there was some inserted emoji :?: that does not work, and all emojis uploaded after that, did neither.