Rocket.chat: There shouldn't be empty buttons on the web interface

[mgifford]

Description:

Empty buttons present accessibility problems for people with disabilities. These should be explicitly hidden or not present.

This presents a problem for WCAG 2.0 AA requirements.

Steps to Reproduce:

1. Load up a rocket chat in a web browser
2. Run the wave toolbar http://wave.webaim.org/extension/
3. Look for all of the red boxes

Expected behavior:

There should be no empty buttons or links.

Actual behavior:

There are empty buttons

[Cambridgeport90]

Thanks @mgifford. I just want to also point out the fact that this is present no matter which interface you use; hardly any of the buttons are labeled at all; I am blind myself, using text to speech. I get lots of "button" and "clickable" when navigating throughout the interface because no screen reader can see behind the buttons and other controls with no labels. I'll pop up a menu and still not figure out how I did it. This is a huge problem.

[mgifford]

Thanks @Cambridgeport90 - I appreciate you verifying this issue. The first step to fix these problems is to report them. Point to the W3C standards where the guidelines are laid out. It doesn't always work, but if enough people do it.

Happy to help try work with you to identify some of these.

[Cambridgeport90]

The majority of it is missing labels. I’ll see if I can find the guidelines exactly where it is, but it’s easier to describe what I experience than for me to try and put it into programming terms in this case. Unfortunately, Electron’s the wrong language. For me, at least.

[HammyHavoc]

If I have some free time in the next few days then I'll attempt to tackle this for you, @Cambridgeport90. I work with several legally blind users, there's a lot of work to be done on Rocket.Chat in regards to being accessible. One user has some sight, though the bright white UX makes Rocket.Chat impossible to use, so resorts to Wave.

Currently reading through the Web Accessibility Initiative on W3C.

[graywolf336]

Should anyone submit a pull requests to fix these issues, please tag me. If they're in before our cut off date for the next release, which is the 20th of each month, then I'll try my best to ensure they get merged. I say let's start small and incrementally fix them instead of trying to fix everything in one run.

[Cambridgeport90]

Agreed. Work up to completely accessible while in the short run making it useable.

[mgifford]

It's a journey, not a destination. There are always ways of making things more usable & accessible. This one is just low-hanging-fruit. Should be fairly straight forward.

[Cambridgeport90]

Please. Keep me updated. I love your enthusiasm. If I knew electron, I’d lend a hand directly.

From: Mike Gifford [e-mail]
Sent: 14 April 2018 18:47
To: RocketChat/Rocket.Chat [e-mail]
Cc: Katherine M. Moss [e-mail]; Mention [e-mail]
Subject: Re: [RocketChat/Rocket.Chat] There shouldn't be empty buttons on the web interface (#10379)

It's a journey, not a destination. There are always ways of making things more usable & accessible. This one is just low-hanging-fruit. Should be fairly straight forward.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/RocketChat/Rocket.Chat/issues/10379#issuecomment-381366028, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOXGAPRn4zvyzqXk4rFddWLX58S9TFu1ks5tonxWgaJpZM4TLHuA.

[geekgonecrazy]

Is this still an issue?

[mgifford]

I still see it in the instance I use. But I don't maintain it and am not sure what version of the software it is using. I assume it is updated.

EDIT: Just saw a notice that it was updated to https://github.com/RocketChat/Rocket.Chat/releases/tag/0.72.0 last night

[geekgonecrazy]

👍 sounds like still is an issue then

[Cambridgeport90]

I haven’t been up here using this in quite a long time, so I wouldn’t be able to tell you at this point in time. It’s fine if you want to close it.

From: Aaron Ogle [e-mail]
Sent: Saturday, December 1, 2018 4:22 AM
To: RocketChat/Rocket.Chat [e-mail]
Cc: Katherine M. Moss [e-mail]; Mention [e-mail]
Subject: Re: [RocketChat/Rocket.Chat] There shouldn't be empty buttons on the web interface (#10379)

Is this still an issue?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/RocketChat/Rocket.Chat/issues/10379#issuecomment-443412694, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOXGAPQFPV2BOkzE912IgsZaLFUXORF7ks5u0kpKgaJpZM4TLHuA.